Skip to content

[SPIR-V] Initial support of FPGA loop attributes/pragmas #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2019

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented May 21, 2019

Following attributes/pragmas are supported:

ivdep
ivdep safelen (N)
ii(N)
max_concurrency_loop(N)
LLVM IR ->SPIRV translation (appropriately the set order):

!"llvm.loop.ivdep.enable ->
4 LoopMerge {{[0-9]+}} {{[0-9]+}} 4
!"llvm.loop.ivdep.safelen", i32 N ->
5 LoopMerge {{[0-9]+}} {{[0-9]+}} 8 N
!"llvm.loop.ii.count", i32 N ->
6 LoopMerge {{[0-9]+}} {{[0-9]+}} 0x80000000 5889 N
!"llvm.loop.max_concurrency.count", i32 N ->
6 LoopMerge {{[0-9]+}} {{[0-9]+}} 0x80000000 5890 N
Also a case of multiple bit masks set for LoopControl is
now supported.

SPEC: KhronosGroup/SPIRV-Registry#28

Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com

@MrSidims MrSidims requested a review from bader May 21, 2019 11:05
@MrSidims MrSidims changed the title Following attributes/pragmas are supported: Initial support of FPGA loop attributes/pragmas May 21, 2019
bader
bader previously approved these changes May 21, 2019
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to add a tag to this commit.
Something like "[SPIR-V] Add initial support for FPGA loop attributes/pragmas".

@MrSidims MrSidims changed the title Initial support of FPGA loop attributes/pragmas [SPIR-V] Initial support of FPGA loop attributes/pragmas May 21, 2019
@bader
Copy link
Contributor

bader commented May 21, 2019

I think it would be useful to add a tag to this commit.
Something like "[SPIR-V] Add initial support for FPGA loop attributes/pragmas".

This request is about changing the commit message, not the PR title.
NOTE: we use "rebase and merge" strategy, so PR title is not recorded in the git - only your commits.

Following attributes/pragmas are supported:

ivdep
ivdep safelen (N)
ii(N)
max_concurrency_loop(N)
LLVM IR ->SPIRV translation (appropriately the set order):

!"llvm.loop.ivdep.enable ->
4 LoopMerge {{[0-9]+}} {{[0-9]+}} 4
!"llvm.loop.ivdep.safelen", i32 N ->
5 LoopMerge {{[0-9]+}} {{[0-9]+}} 8 N
!"llvm.loop.ii.count", i32 N ->
6 LoopMerge {{[0-9]+}} {{[0-9]+}} 0x80000000 5889 N
!"llvm.loop.max_concurrency.count", i32 N ->
6 LoopMerge {{[0-9]+}} {{[0-9]+}} 0x80000000 5890 N
Also a case of multiple bit masks set for LoopControl is
now supported.

SPEC: KhronosGroup/SPIRV-Registry#28

Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com
@MrSidims MrSidims force-pushed the private/MrSidims/LoopAttrSPV branch from 7a29946 to 0e1424f Compare May 21, 2019 12:25
@MrSidims MrSidims requested a review from bader May 21, 2019 15:32
@bader bader merged commit b39e552 into intel:sycl May 22, 2019
vmaksimo pushed a commit to vmaksimo/llvm that referenced this pull request Jan 25, 2021
  CONFLICT (content): Merge conflict in llvm/lib/Support/Triple.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants