Skip to content

[SYCL] Update C++ standard for DPC++ runtime to C++14 #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2020
Merged

[SYCL] Update C++ standard for DPC++ runtime to C++14 #1556

merged 2 commits into from
Apr 27, 2020

Conversation

dm-vodopyanov
Copy link
Contributor

Signed-off-by: Dmitry Vodopyanov dmitry.vodopyanov@intel.com

@dm-vodopyanov
[SYCL] Update C++ standard for DPC++ RT to C++14
1fad34a 
Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@dm-vodopyanov dm-vodopyanov requested review from kbobrovs, pvchupin and a team as code owners April 20, 2020 16:10
@dm-vodopyanov dm-vodopyanov requested a review from s-kanaev April 20, 2020 16:10
s-kanaev
s-kanaev reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Need to see tests results.

s-kanaev
s-kanaev previously approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ruyk
Ruyk reviewed Apr 21, 2020
View reviewed changes
@dm-vodopyanov
[SYCL] Update C++ standard information
d820a51 
Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@dm-vodopyanov dm-vodopyanov requested review from s-kanaev and a team April 24, 2020 16:52
s-kanaev
s-kanaev approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader requested a review from mdtoguchi April 27, 2020 10:52
bader
bader reviewed Apr 27, 2020
View reviewed changes
@bader bader merged commit 791667f into intel:sycl Apr 27, 2020
@dm-vodopyanov dm-vodopyanov deleted the private/dvodopya/update_dpcpp_rt_to_cpp14 branch April 30, 2020 10:13
bb-sycl pushed a commit that referenced this pull request Sep 15, 2022
@jcranmer-intel @dbudanov-cmplr
Rework the demangler to support recovering more pointer element types. (
f5f1d49 
#1556)

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@b412ae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@kbobrovs kbobrovs Awaiting requested review from kbobrovs

@mdtoguchi mdtoguchi Awaiting requested review from mdtoguchi

+3 more reviewers

@Ruyk Ruyk Ruyk left review comments

@pvchupin pvchupin pvchupin approved these changes

@s-kanaev s-kanaev s-kanaev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dm-vodopyanov @bader @Ruyk @pvchupin @mdtoguchi @s-kanaev