[SYCL][E2E] Re-enable `interop_all_backends.cpp` test #15767

ayylol · 2024-10-18T19:07:57Z

The capitalization of cuda and hip in Basic/interop/interop_all_backends.cpp makes the test always unsupported. This patch removes the requires line, and refactors how the test is built so that we build an executable for each backend.

sycl/test-e2e/ESIMD/noinline_call_recursive.cpp

againull · 2024-10-21T23:49:34Z

sycl/test-e2e/Basic/interop/interop_all_backends.cpp

-// REQUIRES: CUDA || HIP
-// RUN: %{build} %if hip %{ -DSYCL_EXT_ONEAPI_BACKEND_HIP %} %else %{ %if cuda %{ -DSYCL_EXT_ONEAPI_BACKEND_CUDA_EXPERIMENTAL %} %else %{ %if level_zero %{ -DSYCL_EXT_ONEAPI_BACKEND_L0 %} %} %} -o %t.out
+// REQUIRES: cuda || hip
+// RUN: %{build} %if any-device-is-hip %{ -DSYCL_EXT_ONEAPI_BACKEND_HIP %} %else %{ %if any-device-is-cuda %{ -DSYCL_EXT_ONEAPI_BACKEND_CUDA_EXPERIMENTAL %} %else %{ %if any-device-is-level_zero %{ -DSYCL_EXT_ONEAPI_BACKEND_L0 %} %} %} -o %t.out


This way we will build an executable only for hip, or only for cuda, or only for l0.
Probably this line should be split into three lines with different executable names.

sarnex · 2024-10-25T18:17:33Z

@ayylol Test is failing on HIP in postcommit unfortunately. Think you can fix it quickly? If not let's revert for now

https://github.com/intel/llvm/actions/runs/11523103039/job/32080880588

-- Testing: 2233 tests, 24 workers --
FAIL: SYCL :: Basic/interop/interop_all_backends.cpp (278 of 2233)
******************** TEST 'SYCL :: Basic/interop/interop_all_backends.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3 has no command after substitutions
# RUN: at line 4 has no command after substitutions
# RUN: at line 5 has no command after substitutions
# RUN: at line 6
/__w/llvm/llvm/toolchain/bin//clang++  -Werror -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1031 -fsycl -fsycl-targets=amdgcn-amd-amdhsa  /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp -DBUILD_FOR_HIP -o /__w/llvm/llvm/build-e2e/Basic/interop/Output/interop_all_backends.cpp.tmp-hip.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -Werror -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1031 -fsycl -fsycl-targets=amdgcn-amd-amdhsa /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp -DBUILD_FOR_HIP -o /__w/llvm/llvm/build-e2e/Basic/interop/Output/interop_all_backends.cpp.tmp-hip.out
# .---command stderr------------
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:23:22: error: unknown type name 'hipDevice_t'
# |    23 | using nativeDevice = hipDevice_t;
# |       |                      ^
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:24:21: error: unknown type name 'hipStream_t'; did you mean 'ihipStream_t'?
# |    24 | using nativeQueue = hipStream_t;
# |       |                     ^~~~~~~~~~~
# |       |                     ihipStream_t
# | /__w/llvm/llvm/toolchain/bin/../include/sycl/detail/backend_traits_hip.hpp:26:16: note: 'ihipStream_t' declared here
# |    26 | typedef struct ihipStream_t *HIPstream;
# |       |                ^
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:25:21: error: unknown type name 'hipEvent_t'; did you mean 'ihipEvent_t'?
# |    25 | using nativeEvent = hipEvent_t;
# |       |                     ^~~~~~~~~~
# |       |                     ihipEvent_t
# | /__w/llvm/llvm/toolchain/bin/../include/sycl/detail/backend_traits_hip.hpp:27:16: note: 'ihipEvent_t' declared here
# |    27 | typedef struct ihipEvent_t *HIPevent;
# |       |                ^
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:45:22: error: use of undeclared identifier 'nativeDevice'
# |    45 |                      nativeDevice>));
# |       |                      ^
# | 4 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

sarnex · 2024-10-25T18:42:35Z

@ayylol Failing on DG2 also

/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:664: note: Found pre-installed AOT device compiler ocloc
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:664: note: Found pre-installed AOT device compiler opencl-aot
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:756: note: Aspects for level_zero:gpu: gpu, usm_shared_allocations, ext_intel_gpu_subslices_per_slice, queue_profiling, online_linker, atomic64, ext_intel_matrix, ext_intel_pci_address, ext_intel_gpu_eu_simd_width, usm_host_allocations, ext_oneapi_bindless_images_2d_usm, fp16, ext_intel_gpu_slices, ext_oneapi_virtual_functions, ext_oneapi_bindless_images_1d_usm, ext_intel_device_id, ext_intel_legacy_image, usm_device_allocations, ext_oneapi_opportunistic_group, ext_intel_esimd, ext_oneapi_virtual_mem, ext_intel_gpu_eu_count, ext_oneapi_fixed_size_group, ext_intel_memory_bus_width, ext_oneapi_bindless_images, ext_oneapi_private_alloca, ext_intel_gpu_eu_count_per_subslice, ext_oneapi_queue_profiling_tag, ext_oneapi_ballot_group, online_compiler, ext_oneapi_limited_graph, ext_intel_free_memory, ext_intel_memory_clock_rate, ext_intel_gpu_hw_threads_per_eu, ext_intel_device_info_uuid, ext_oneapi_tangle_group
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:768: note: SG sizes for level_zero:gpu: 8, 32, 16
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:777: note: Architectures for level_zero:gpu: intel_gpu_acm_g10
-- Testing: 2233 tests, 24 workers --
FAIL: SYCL :: Basic/interop/interop_all_backends.cpp (276 of 2233)
******************** TEST 'SYCL :: Basic/interop/interop_all_backends.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3 has no command after substitutions
# RUN: at line 4
/__w/llvm/llvm/toolchain/bin//clang++  -Werror  -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp -DBUILD_FOR_L0 -o /__w/llvm/llvm/build-e2e/Basic/interop/Output/interop_all_backends.cpp.tmp-l0.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -Werror -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp -DBUILD_FOR_L0 -o /__w/llvm/llvm/build-e2e/Basic/interop/Output/interop_all_backends.cpp.tmp-l0.out
# .---command stderr------------
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:65:23: error: no matching function for call to 'make_queue'
# |    65 |   auto InteropQueue = make_queue<BACKEND>(NativeQueue, Context);
# |       |                       ^~~~~~~~~~~~~~~~~~~
# | /__w/llvm/llvm/toolchain/bin/../include/sycl/backend.hpp:348:1: note: candidate function template not viable: no known conversion from 'backend_traits<BACKEND>::return_type<queue>' (aka 'variant<_ze_command_queue_handle_t *, _ze_command_list_handle_t *>') to 'const typename backend_traits<(backend)'\x02'>::template input_type<queue>' (aka 'const sycl::detail::BackendInput<sycl::backend::ext_oneapi_level_zero, sycl::queue>::type') for 1st argument
# |   348 | make_queue(const typename backend_traits<Backend>::template input_type<queue>
# |       | ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |   349 |                &BackendObject,
# |       |                ~~~~~~~~~~~~~~
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:78:24: error: no matching function for call to 'make_event'
# |    78 |   event InteropEvent = make_event<BACKEND>(NativeEvent, Context);
# |       |                        ^~~~~~~~~~~~~~~~~~~
# | /__w/llvm/llvm/toolchain/bin/../include/sycl/backend.hpp:361:1: note: candidate function template not viable: cannot convert argument of incomplete type 'backend_traits<BACKEND>::return_type<event>' (aka '_ze_event_handle_t *') to 'const typename backend_traits<(backend)'\x02'>::template input_type<event>' (aka 'const sycl::detail::BackendInput<sycl::backend::ext_oneapi_level_zero, sycl::event>::type') for 1st argument
# |   361 | make_event(const typename backend_traits<Backend>::template input_type<event>
# |       | ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |   362 |                &BackendObject,
# |       |                ~~~~~~~~~~~~~~
# | /__w/llvm/llvm/toolchain/bin/../include/sycl/backend.hpp:371:25: note: candidate function template not viable: requires 3 arguments, but 2 were provided
# |   371 |                  event> make_event(const typename backend_traits<Backend>::
# |       |                         ^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |   372 |                                        template input_type<event>
# |       |                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~
# |   373 |                                            &BackendObject,
# |       |                                            ~~~~~~~~~~~~~~~
# |   374 |                                    const context &TargetContext,
# |       |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |   375 |                                    bool KeepOwnership) {
# |       |                                    ~~~~~~~~~~~~~~~~~~
# | 2 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

ayylol · 2024-10-25T19:02:46Z

@ayylol Test is failing on HIP in postcommit unfortunately. Think you can fix it quickly? If not let's revert for now

https://github.com/intel/llvm/actions/runs/11523103039/job/32080880588

-- Testing: 2233 tests, 24 workers --
FAIL: SYCL :: Basic/interop/interop_all_backends.cpp (278 of 2233)
******************** TEST 'SYCL :: Basic/interop/interop_all_backends.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3 has no command after substitutions
# RUN: at line 4 has no command after substitutions
# RUN: at line 5 has no command after substitutions
# RUN: at line 6
/__w/llvm/llvm/toolchain/bin//clang++  -Werror -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1031 -fsycl -fsycl-targets=amdgcn-amd-amdhsa  /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp -DBUILD_FOR_HIP -o /__w/llvm/llvm/build-e2e/Basic/interop/Output/interop_all_backends.cpp.tmp-hip.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -Werror -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1031 -fsycl -fsycl-targets=amdgcn-amd-amdhsa /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp -DBUILD_FOR_HIP -o /__w/llvm/llvm/build-e2e/Basic/interop/Output/interop_all_backends.cpp.tmp-hip.out
# .---command stderr------------
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:23:22: error: unknown type name 'hipDevice_t'
# |    23 | using nativeDevice = hipDevice_t;
# |       |                      ^
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:24:21: error: unknown type name 'hipStream_t'; did you mean 'ihipStream_t'?
# |    24 | using nativeQueue = hipStream_t;
# |       |                     ^~~~~~~~~~~
# |       |                     ihipStream_t
# | /__w/llvm/llvm/toolchain/bin/../include/sycl/detail/backend_traits_hip.hpp:26:16: note: 'ihipStream_t' declared here
# |    26 | typedef struct ihipStream_t *HIPstream;
# |       |                ^
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:25:21: error: unknown type name 'hipEvent_t'; did you mean 'ihipEvent_t'?
# |    25 | using nativeEvent = hipEvent_t;
# |       |                     ^~~~~~~~~~
# |       |                     ihipEvent_t
# | /__w/llvm/llvm/toolchain/bin/../include/sycl/detail/backend_traits_hip.hpp:27:16: note: 'ihipEvent_t' declared here
# |    27 | typedef struct ihipEvent_t *HIPevent;
# |       |                ^
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/interop/interop_all_backends.cpp:45:22: error: use of undeclared identifier 'nativeDevice'
# |    45 |                      nativeDevice>));
# |       |                      ^
# | 4 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

I'll open a pr marking it as XFAIL: *

sarnex · 2024-10-25T19:04:25Z

it's passing on some devices, so if we're doing XFAIL it should be gpu-intel-dg2 || hip_amd i think

Fix typos in REQUIRES: lines

c521292

ayylol requested review from a team as code owners October 18, 2024 19:07

ayylol requested a review from sergey-semenov October 18, 2024 19:07

ayylol temporarily deployed to WindowsCILock October 18, 2024 19:08 — with GitHub Actions Inactive

sarnex reviewed Oct 18, 2024

View reviewed changes

sycl/test-e2e/ESIMD/noinline_call_recursive.cpp Outdated Show resolved Hide resolved

ayylol temporarily deployed to WindowsCILock October 18, 2024 19:21 — with GitHub Actions Inactive

Revert change to ESIMD test

88db4cf

ayylol had a problem deploying to WindowsCILock October 21, 2024 17:03 — with GitHub Actions Error

ayylol changed the title ~~[SYCL][E2E] Fix typos in REQUIRES: lit lines~~ [SYCL][E2E] Fix capitalization in REQUIRES: lit line Oct 21, 2024

Use any-device-is- in build line of test

10a0773

ayylol temporarily deployed to WindowsCILock October 21, 2024 17:46 — with GitHub Actions Inactive

ayylol temporarily deployed to WindowsCILock October 21, 2024 18:51 — with GitHub Actions Inactive

againull reviewed Oct 21, 2024

View reviewed changes

Split build line and add level_zero

2881596

ayylol temporarily deployed to WindowsCILock October 22, 2024 14:08 — with GitHub Actions Inactive

ayylol had a problem deploying to WindowsCILock October 22, 2024 14:56 — with GitHub Actions Failure

Restructure test

9bc41b6

ayylol temporarily deployed to WindowsCILock October 22, 2024 19:48 — with GitHub Actions Inactive

againull approved these changes Oct 22, 2024

View reviewed changes

ayylol changed the title ~~[SYCL][E2E] Fix capitalization in REQUIRES: lit line~~ [SYCL][E2E] Re-enableBasic/interop/interop_all_backends.cpp test Oct 22, 2024

ayylol changed the title ~~[SYCL][E2E] Re-enableBasic/interop/interop_all_backends.cpp test~~ [SYCL][E2E] Re-enable interop_all_backends.cpp test Oct 22, 2024

ayylol had a problem deploying to WindowsCILock October 22, 2024 20:43 — with GitHub Actions Error

ayylol mentioned this pull request Oct 22, 2024

[SYCL][E2E] Basic/interop/interop_all_backends.cpp and OptionalKernelFeatures/is_compatible/is_compatible_several_targets.cpp failed after re-enabling #15819

Open

ayylol added 2 commits October 22, 2024 14:13

Add XFAIL to test

33913ef

Merge branch 'sycl' into requires-typo

56d9432

ayylol had a problem deploying to WindowsCILock October 22, 2024 21:16 — with GitHub Actions Error

change xfail * to specific xfail

a1d3bcf

ayylol temporarily deployed to WindowsCILock October 22, 2024 21:20 — with GitHub Actions Inactive

ayylol had a problem deploying to WindowsCILock October 22, 2024 22:03 — with GitHub Actions Failure

Merge branch 'sycl' into requires-typo

c224b81

ayylol temporarily deployed to WindowsCILock October 24, 2024 17:15 — with GitHub Actions Inactive

ayylol had a problem deploying to WindowsCILock October 24, 2024 18:41 — with GitHub Actions Failure

ayylol added 2 commits October 25, 2024 08:06

Merge branch 'sycl' into requires-typo

2f68d8f

Add xfail for windows level_zero

754f763

ayylol temporarily deployed to WindowsCILock October 25, 2024 15:08 — with GitHub Actions Inactive

ayylol temporarily deployed to WindowsCILock October 25, 2024 16:07 — with GitHub Actions Inactive

ayylol mentioned this pull request Oct 25, 2024

[SYCL][E2E] Add functionality to split build and run of e2e tests #15728

Closed

againull merged commit 7e2d615 into intel:sycl Oct 25, 2024
13 checks passed

ayylol deleted the requires-typo branch October 25, 2024 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][E2E] Re-enable `interop_all_backends.cpp` test #15767

[SYCL][E2E] Re-enable `interop_all_backends.cpp` test #15767

Uh oh!

ayylol commented Oct 18, 2024 •

edited

Loading

Uh oh!

Uh oh!

againull Oct 21, 2024 •

edited

Loading

Uh oh!

Uh oh!

sarnex commented Oct 25, 2024 •

edited

Loading

Uh oh!

sarnex commented Oct 25, 2024

Uh oh!

ayylol commented Oct 25, 2024

Uh oh!

sarnex commented Oct 25, 2024

Uh oh!

Uh oh!

[SYCL][E2E] Re-enable interop_all_backends.cpp test #15767

[SYCL][E2E] Re-enable interop_all_backends.cpp test #15767

Uh oh!

Conversation

ayylol commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

againull Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sarnex commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarnex commented Oct 25, 2024

Uh oh!

ayylol commented Oct 25, 2024

Uh oh!

sarnex commented Oct 25, 2024

Uh oh!

Uh oh!

[SYCL][E2E] Re-enable `interop_all_backends.cpp` test #15767

[SYCL][E2E] Re-enable `interop_all_backends.cpp` test #15767

ayylol commented Oct 18, 2024 •

edited

Loading

againull Oct 21, 2024 •

edited

Loading

sarnex commented Oct 25, 2024 •

edited

Loading