Skip to content

[SYCL][E2E] Add USM compatibility test for sycl_ext_oneapi_virtual_mem extension #15974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dyniols
Copy link
Contributor

@dyniols dyniols commented Nov 4, 2024

Based on the test plan #15509, this PR adds an E2E test to ensure that USM APIs also accept the pointer to virtual memory.

@dyniols dyniols marked this pull request as ready for review November 5, 2024 11:28
@dyniols dyniols requested a review from a team as a code owner November 5, 2024 11:28
@dyniols dyniols requested a review from uditagarwal97 November 5, 2024 11:28
@dyniols
Copy link
Contributor Author

dyniols commented Nov 7, 2024

@uditagarwal97 Could you review this PR?

@uditagarwal97
Copy link
Contributor

I'd also reword the PR description a little. Perhaps something like the following:

Based on the test plan #15509, this PR adds an E2E test to ensure that USM APIs also accept the pointer to virtual memory.

dyniols and others added 2 commits November 7, 2024 18:20
Co-authored-by: Udit Agarwal <dev.madaari@gmail.com>
Co-authored-by: Udit Agarwal <dev.madaari@gmail.com>
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dyniols
Copy link
Contributor Author

dyniols commented Nov 12, 2024

@intel/llvm-gatekeepers Can we merge this PR?

@steffenlarsen steffenlarsen merged commit 1d36e14 into intel:sycl Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants