Skip to content

[SYCL] Add missing special values to exp(complex) #15980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2024
Merged

[SYCL] Add missing special values to exp(complex) #15980

merged 5 commits into from
Nov 7, 2024

Conversation

KornevNikita
Copy link
Contributor

Follow-up to #15672
This patch updates float behavior

@KornevNikita
[SYCL] Follow-up to exp(complex) update
2d1dea0 
Follow-up to intel#15672
This patch updates float behavior
@KornevNikita KornevNikita requested a review from a team as a code owner November 4, 2024 19:50
bader
bader reviewed Nov 4, 2024
View reviewed changes
@jinge90
Fix failed corner cases on Linux platform
5dc1f88 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
Copy link
Contributor

jinge90 commented Nov 7, 2024

Hi, @KornevNikita
I just committed a little fix to remove lit failure on Linux but Windows failure is still there.
I will check Windows later. Things are different for Windows, we didn't provide any complex math functions for Windows since MSVC C++ headers included them, we just enabled these functions on Windows by providing some functions invoked in these complex functions.
Thanks very much.

@KornevNikita
Copy link
Contributor Author

@jinge90 very appreciated! thanks!

@KornevNikita
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge

@sarnex
Copy link
Contributor

sarnex commented Nov 7, 2024

can you improve the title?

@KornevNikita KornevNikita changed the title [SYCL] Follow-up to exp(complex) update [SYCL] Add missing special values to exp(complex) Nov 7, 2024
@KornevNikita
Copy link
Contributor Author

@sarnex is it OK?

@sarnex
Copy link
Contributor

sarnex commented Nov 7, 2024

yeah nice thx

@sarnex sarnex merged commit aebfdc0 into intel:sycl Nov 7, 2024
13 checks passed
@againull againull mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KornevNikita @jinge90 @sarnex @bader @steffenlarsen