[UR][SYCL] Remove UR context atomic queries. #16160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
These were always just used as placeholder values so they can be replaced by __SYCL_TRAIT_HANDLED_IN_RT.
aarongreig
force-pushed
the
aaron/removeURContextAtomicQueries
branch
from
5252593 to
a75dafc
Compare
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Is it because it is the right way to do this or just because it so happened? |
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
The queries are all implemented via |
|
CI fail is unrelated, I think something's wrong with that windows runner |
aelovikov-intel
approved these changes
Jan 23, 2025
Both yes and no :) yes: #16757 |
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
These were used as dummy values in the sycl runtime to implement meta-queries for each device in the given context. The affiliated LLVM change for this PR updates that to use __SYCL_TRAIT_HANDLED_IN_RT instead. Fixes intel#2119
|
UR changes ported from oneapi-src/unified-runtime#2374 |
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
approved these changes
Feb 24, 2025
frasercrmck
approved these changes
Feb 24, 2025
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
approved these changes
Mar 7, 2025
|
@intel/llvm-gatekeepers please merge |
adamfidel
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 11, 2025
These were always just used as placeholder values so they can be replaced by __SYCL_TRAIT_HANDLED_IN_RT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were always just used as placeholder values so they can be replaced by __SYCL_TRAIT_HANDLED_IN_RT.