-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL][Doc] Add slm_per_subslice query for Xe GPUs #16376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
@gmlueck - I've opened this as a draft because I think that's your preferred workflow for updates to supported extensions, but this is ready for review. |
@gmlueck, Intel introduced new terminology for GPUs in 2022. I think we should update DPC++ documentation/specifications to use new terminology at some point. |
The APIs in this extension are all pass-throughs to Level Zero. It seems like the Level Zero documentation is still using the old terminology: |
But do our customers care about whether or not this is a pass-through to L0? We already have asks to update the used terminology: #16068 |
I think many customers who call these low-level APIs do know about the Level Zero interfaces, though. Using different terms in the SYCL API may add more confusion since it will be unclear how the SYCL API relates to the Level Zero one. In addition, all the other APIs in this extension use the old terminology, so it would be weird to change just this one. Updating the SYCL terminology seems like a good goal, but I'd rather do it in conjunction with changes to the Level Zero API. |
@Pennycook It seems like the issues above are resolved? If that is the case, then I'd suggest:
I forget which customer request lead to this proposal, but we should include that in the tracker if possible. |
Extends sycl_ext_intel_device_info with a new query for the amount of SLM per subslice. The amount of SLM per subslice may be greater than the amount of memory available to a single work-group, and can be used to reason about occupancy. Signed-off-by: John Pennycook <john.pennycook@intel.com>
6b68096
to
31d410d
Compare
Resolving the merge conflicts was too hard -- the other changes introduced lots of similar subsections, and CMPLRLLVM-64348 already exists to track the implementation, and CMPLRLLVM-64179 is the original customer request. |
Extends sycl_ext_intel_device_info with a new query for the amount of SLM per subslice. The amount of SLM per subslice may be greater than the amount of memory available to a single work-group, and can be used to reason about occupancy.