Skip to content

Conversation

AlexeySachkov
Copy link
Contributor

@AlexeySachkov AlexeySachkov commented Apr 2, 2025

This is a joined cherry-pick of #17367, #17362 and #17746 intended to fix a few remaining issues we see in 6.1 nightly validation run.

Descriptions of cherry-picked commits:


[SYCL] Disable launch_policy_neg.cpp on Windows (#17367)

Fails to compile on new MSVC.

Patch-by: Sarnie, Nick nick.sarnie@intel.com


[SYCL] Avoid testing race condition

Use no output file instead of default output file in LIT tests.
This occasionally caused errors on windows when multiple files compile
to the same output file. Using -fsyntax-only hjere also avoids running the full compiler pipeline

See #7872 for more context

Patch-By: David Garcia Orozco david.garcia.orozco@intel.com


[SYCL] Fix clang-linker-wrapper Windows test (#17746)

Failing now because I recently added ptxas to the path on these
runners.

Patch-by: Sarnie, Nick nick.sarnie@intel.com


sarnex and others added 3 commits April 2, 2025 02:44
Fails to compile on new MSVC.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Use no output file instead of default output file in LIT tests.
This occasionally caused errors on windows when multiple files compile
to the same output file. Using `-fsyntax-only` hjere also avoids running the full compiler pipeline

See intel#7872 for more context
Failing now because I recently added `ptxas` to the path on these
runners.

---------

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@AlexeySachkov AlexeySachkov marked this pull request as ready for review April 2, 2025 15:43
@AlexeySachkov AlexeySachkov requested review from a team as code owners April 2, 2025 15:43
@AlexeySachkov
Copy link
Contributor Author

SYCL Pre Commit on Windows / build / Build + LIT (pull_request)

This is the main validation check for this PR - it is now green. The rest of the pre-commit is generally still unstable, so I will proceed with merge

@AlexeySachkov AlexeySachkov merged commit d03db3f into intel:sycl-rel-6_1_0 Apr 3, 2025
6 of 16 checks passed
@AlexeySachkov AlexeySachkov deleted the private/asachkov/stabilize-6-1-nighly branch April 3, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants