[libclc] Fix data races in libclc/libspirv LIT tests #17902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple libclc test targets were running essentially the same test suite in parallel. This could result in data races when one target writes a file another target is reading. This commit fixes the issue by creating a unique test execution directory per target. We already have a unique libclc target known as an 'arch suffix' in CMake. This suffix is used as the unique builtins file name. We pass this through to LIT via a parameter to create the execution directory. Note this use of LIT (i.e., having one suite called multiple times in different configurations) is unconventional so there aren't many similar examples in LLVM. Patch proposed by @bader.
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
frasercrmck
changed the title
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
approved these changes
Apr 8, 2025
|
@intel/llvm-gatekeepers this is ready to merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple libclc test targets were running essentially the same test suite in parallel. This could result in data races when one target writes a file another target is reading.
This commit fixes the issue by creating a unique test execution directory per target. We already have a unique libclc target known as an 'arch suffix' in CMake. This suffix is used as the unique builtins file name. We pass this through to LIT via a parameter to create the execution directory. Note this use of LIT (i.e., having one suite called multiple times in different configurations) is unconventional so there aren't many similar examples in LLVM.
Patch proposed by @bader.