[UR] Fix OpenCL handles generated from sub-devices #17931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub-devices don't appear in the list of devices, and so the prior OpenCL implementation would assume that they are invalid. With this patch, creating a sub-device will add it to a "cache" stored in the platform. Multiple `DeviceCreateWithNativeHandle` calls with the same native handle will result in the same UR handle. A test has been added to verify this. This unfortunately required shuffling headers around to avoid circular imports. This fixes an issue tracked internally by Intel as URT-903
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Apr 10, 2025
|
@intel/llvm-gatekeepers Please merge. |
kbenzie
pushed a commit
that referenced
this pull request
Apr 14, 2025
Follow up from #17931, additional fix for URT-903.
kbenzie
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Apr 16, 2025
Follow up from intel/llvm#17931, additional fix for URT-903.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-devices don't appear in the list of devices, and so the prior OpenCL
implementation would assume that they are invalid. With this patch,
creating a sub-device will add it to a "cache" stored in the platform.
Multiple
DeviceCreateWithNativeHandlecalls with the same nativehandle will result in the same UR handle. A test has been added to
verify this.
This unfortunately required shuffling headers around to avoid circular
imports.
This fixes an issue tracked internally by Intel as URT-903