[CI] Add python3-venv to build tools installation #18080
Conversation
| GITHUB_TOKEN=$(cat /run/secrets/github_token) /install_drivers.sh $install_driver_opt --all | ||
|
|
||
| # Install venv for UR pip requirements | ||
| RUN apt update && apt install -y python3-venv |
There was a problem hiding this comment.
not sure i understand why only this one has this, i would expect all images used for using a gpu need it, so i would expect it needs to be added to ubuntu2404_base
There was a problem hiding this comment.
I added there because I am using only ubuntu2404_intel_drivers:alldeps and ubuntu2204_build:latest image so venv is no needed in all of images
There was a problem hiding this comment.
this file isnt doesnt contribute to ubuntu2404_intel_drivers:alldeps i think
There was a problem hiding this comment.
yeah, I mixed up the files but now it is in correct place.
There was a problem hiding this comment.
can we instead add it here https://github.com/intel/llvm/blob/f2028848c7ddf2af6420d141cac056059abdc8be/devops/scripts/install_build_tools.sh
then we only need to modify one spot total
There was a problem hiding this comment.
thanks for prompt, I updated it
There was a problem hiding this comment.
we can remove this now right?
lukaszstolarczuk
changed the title
|
@sarnex, works for me. If no more approvals are required this is ready for merge, I believe. |
- [x] wait for #18080 --------- Signed-off-by: rbanka1 <renata.banka@intel.com>
So it will be available in the docker images. Required for UR workflows.