[CI] Fix post-commit Windows job #18322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
reviewed
May 5, 2025
| @@ -244,6 +244,7 @@ jobs: | |||
| target_devices: all | |||
| binaries_artifact: ${{ inputs.e2e_binaries_artifact }} | |||
| extra_lit_opts: --param sycl_build_targets="spir" | |||
| compiler: cl | |||
There was a problem hiding this comment.
can we make this the default value so we dont have to pass it?
sarnex
reviewed
May 5, 2025
Comment on lines
18
to
+21
| cxx_compiler: | ||
| required: false | ||
|
|
||
| compiler: | ||
| required: false |
There was a problem hiding this comment.
Do we really need cxx_compiler and compiler? Can't we just use cxx_compiler?
There was a problem hiding this comment.
From what I understand the difference is that compiler is what we use to build the project, while cxx_compiler is the path to the compiler we build.
There was a problem hiding this comment.
ah ok, can you rename the vars to be clear?
sarnex
approved these changes
May 6, 2025
sarnex
pushed a commit
that referenced
this pull request
May 6, 2025
We have `cxx` and `cxx_compiler`, very similar names so it can be confusing. `cxx` is used to build the project, while `cxx_compiler` is the compiler produced so renaming the latter to `sycl_compiler`. Additionally aligning the Windows with the Linux build job by renaming `compiler` to `cxx`. Addresses comments from #18322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18124 broke the windows post-commit, this should fix that due to removing the
compilervariable from the E2E composite action, as well as not having listed a target device. This should fix that.