[SYCL] Revert prepare-builtins change for non-NativeCPU. #18490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In intel#17999 I changed prepare-builtins to clear target-cpu and target-features for NativeCPU, and attempted to preserve existing behavior for other targets. For NativeCPU, two errors cancelled each other out so we do the right thing there, but for other targets, that is not the case and target-cpu and target-features were also being cleared unintentionally.
ldrumm
approved these changes
May 15, 2025
|
@intel/llvm-gatekeepers This is ready to merge, thanks. CI failures are unrelated and have previously been reported as #18463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17999 I changed prepare-builtins to clear target-cpu and target-features for NativeCPU, and attempted to preserve existing behavior for other targets. For NativeCPU, two errors cancelled each other out so we do the right thing there, but for other targets, that is not the case and target-cpu and target-features were also being cleared unintentionally.