Skip to content

[CI][UR][Offload] Add Offload build-only job #18700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 10, 2025

Conversation

RossBrunton
Copy link
Contributor

Add a new job that verifies that the offload adapter can be built.
It does not attempt to run any tests or detect any hardware.

@RossBrunton RossBrunton changed the title [CI][UR][Offload] Add UR build-only job [CI][UR][Offload] Add Offload build-only job May 28, 2025
@RossBrunton RossBrunton marked this pull request as ready for review May 28, 2025 15:27
@RossBrunton RossBrunton requested a review from a team as a code owner May 28, 2025 15:27
build_type: [Release]
compiler: [{c: gcc, cxx: g++}]

runs-on: "ubuntu-24.04"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to use one of our build runners? i expect these ones are really slow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we should do this, any reason you didn't already @RossBrunton ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason other than the fact that ur-source-checks and ur-benchmarks don't. What runner should I be using for this? It doesn't need any fancy GPUs or libraries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should use a UR CI machine, @igchor any ideas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set the job to use [ "self-hosted", "Linux", "build" ], which means it should use any runner that is free to build it. This matches the sycl build jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarnex @igchor The current version of this MR is using the same self-hosted runners as the sycl-linux-build job. Is that okay for now at least?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah should be fine


- name: Build
# This is so that device binaries can find the sycl runtime library
run: cmake --build build -j $(nproc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add -GNinja to the cmake you don't need -j

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using Make to be consistent with the ur-build-hw jobs.

@RossBrunton
Copy link
Contributor Author

@sarnex This is green now, any further comments?

@RossBrunton
Copy link
Contributor Author

@sarnex @kbenzie Can I get this looked at again?

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments!

RossBrunton and others added 7 commits July 9, 2025 16:37
Add a new job that verifies that the offload adapter can be built.
It does not attempt to run any tests or detect any hardware.
Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
@RossBrunton
Copy link
Contributor Author

@intel/llvm-gatekeepers Please merge.

@uditagarwal97 uditagarwal97 merged commit 5efbbb6 into intel:sycl Jul 10, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants