Skip to content

Conversation

wlemkows
Copy link
Contributor

@wlemkows wlemkows requested a review from a team as a code owner June 12, 2025 14:03
Copy link
Contributor

@PatKamin PatKamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add information on --filter and --preset. I would say that these are as commonly used parameters as the ones already mentioned in this readme.

are stored [here](https://oneapi-src.github.io/unified-runtime/performance/).

## Output formats
### Output formats
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the extra # intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this fits into the subsection of “Results”.

Comment on lines 98 to 103
## Contribution

The requirements and instructions above are for building the project from source
without any modifications. To make modifications to the specification, please see the
[Contribution Guide](https://oneapi-src.github.io/unified-runtime/core/CONTRIB.html)
for more detailed instructions on the correct setup.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the UR CONTRIB actually relevant for benchmark scripts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be dropped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should remove the entire Contribution section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the section could be removed as there is a CONTRIB.md file in the same directory with a description of contributing to benchmarks framework. Contributions to Unified Runtime are irrelevant to the benchmarks framework

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to leave this section because it finishes the README nicely. I've updated the link to the benchmarks CONTRIB.

@PatKamin
Copy link
Contributor

@intel/llvm-gatekeepers, please merge

@ldrumm
Copy link
Contributor

ldrumm commented Jul 10, 2025

@intel/llvm-gatekeepers, please merge

Can you please provide

@ldrumm ldrumm closed this Jul 10, 2025
@ldrumm ldrumm reopened this Jul 10, 2025
@ldrumm
Copy link
Contributor

ldrumm commented Jul 10, 2025

Sorry. Accidentally pressed all the wrong buttons.

@ldrumm ldrumm merged commit 642fa86 into intel:sycl Jul 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants