memory resident limit to enabled peers #19257
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslusarczyk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
igchor
reviewed
Jul 2, 2025
| ZeOffsetToImageHandleMap; | ||
|
|
||
| // devices which user enabled p2p access by urUsmP2P(Enable|Disable)PeerAccessExp | ||
| std::unordered_set<DeviceId> p2pDeviceIds; |
| { | ||
| std::scoped_lock<ur_shared_mutex> Lock(Platform->ContextsMutex); | ||
| auto It = std::find(Contexts.begin(), Contexts.end(), hContext); | ||
| UR_ASSERT(It != Contexts.end(), UR_RESULT_ERROR_INVALID_CONTEXT); |
There was a problem hiding this comment.
can this happen? should this be just a regular assert?
|
|
||
| void cleanupPools(); | ||
| void cleanupPoolsForQueue(void *hQueue); | ||
| void addResidentDevice(ur_device_handle_t hDevice, ur_device_handle_t peerDevice); |
There was a problem hiding this comment.
Where is this function called from?
| continue; | ||
| } | ||
|
|
||
| if (!p2pDevicesEnabledByUser.has_value()) |
There was a problem hiding this comment.
Why isn't this outside of the loop?
| { | ||
| std::scoped_lock<ur_shared_mutex> Lock(Platform->ContextsMutex); | ||
| for (auto Context : Platform->Contexts) { | ||
| Context->addResidentDevice(commandDevice, peerDevice); |
There was a problem hiding this comment.
What if some context does not contain commandDevice?
|
|
||
| assert(0 = std::count_if( | ||
| std::begin(pDevices), std::end(pDevices), | ||
| [&](const auto pDevice) { return newPeerDevice->Id == pDevice->Id; })); |
There was a problem hiding this comment.
cuCtxEnablePeerAccess returns CUDA_ERROR_PEER_ACCESS_ALREADY_ENABLED. Could we have this error mapped to a UR error? It would help make the peer-to-peer SYCL API more consistent (See #19787.)
lslusarczyk
force-pushed
the
memresident
branch
from
ab67572 to
f1124c5
Compare
lslusarczyk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the Level Zero adapter makes all device allocations resident on all "peer" devices, even if the application doesn't use those peer devices at all. USM residency adds significant overhead.
For v2 unfied-runtime adapter we switch in this PR to not calling zeContextMakeMemoryResident on all devices in the context, just the one that was specified during allocation and those specified using ext_oneapi_enable_peer_access.
When ext_oneapi_enable_peer_access / ext_oneapi_disable_peer_access is called, we retroactively call zeContextMakeMemoryResident or zeContextEvictMemory respectively, on all the active pages in the heap. This is done by calling ctl call in UMF drafted here: oneapi-src/unified-memory-framework@e6d5043
UMF part was done in oneapi-src/unified-memory-framework#1517