Skip to content

[SYCL] Add String utils in libdevice #19356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 24, 2025
Merged

[SYCL] Add String utils in libdevice #19356

merged 15 commits into from
Jul 24, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jul 9, 2025

No description provided.

@jinge90 jinge90 requested a review from a team as a code owner July 9, 2025 07:49
@jinge90 jinge90 requested a review from maarquitos14 July 9, 2025 07:49
@jinge90 jinge90 marked this pull request as draft July 9, 2025 07:49
@jinge90 jinge90 temporarily deployed to WindowsCILock July 9, 2025 07:49 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 9, 2025 08:14 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 9, 2025 08:14 — with GitHub Actions Inactive
@jinge90
[SYCL] Add String utils in libdevice
72c8825 
Signed-off-by: jinge90 <ge.jin@intel.com>
@maarquitos14
Copy link
Contributor

I see this is in draft state, @jinge90 ping me when this is ready to review :)

@jinge90 jinge90 temporarily deployed to WindowsCILock July 10, 2025 07:24 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 10, 2025 07:52 — with GitHub Actions Inactive
@jinge90
add strncmp
8276ac4 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock July 14, 2025 02:07 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 14, 2025 02:32 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 14, 2025 02:32 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 17, 2025 08:25 — with GitHub Actions Inactive
@jinge90
add test for strlen
0cae200 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock July 17, 2025 08:59 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 17, 2025 08:59 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 18, 2025 06:55 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 18, 2025 07:20 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 21, 2025 02:37 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 21, 2025 03:01 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 21, 2025 03:01 — with GitHub Actions Inactive
@jinge90
add test for strcpy strncpy
1bfa231 
Signed-off-by: jinge90 <ge.jin@intel.com>
jinge90 added 2 commits July 21, 2025 15:47
@jinge90
add strncmp lit
cc5d7cb 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
remove dummy file
38e58cd 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 marked this pull request as ready for review July 21, 2025 08:02
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 21, 2025

I see this is in draft state, @jinge90 ping me when this is ready to review :)

Hi, @maarquitos14
Could you help review this PR?
Thanks very much.

jinge90 added 2 commits July 21, 2025 16:26
@jinge90
add new test case for strncmp
e00bc64 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
add strncmp decl in sycl builtins.hpp
7704067 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to WindowsCILock July 22, 2025 02:32 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 22, 2025 02:57 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 22, 2025 02:57 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 23, 2025

I see this is in draft state, @jinge90 ping me when this is ready to review :)

Hi, @maarquitos14 Could you help review this PR? Thanks very much.

Hi, @maarquitos14
Kind ping~~

maarquitos14
maarquitos14 reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just a few nits and questions.

@jinge90 jinge90 temporarily deployed to WindowsCILock July 24, 2025 03:25 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 24, 2025 03:50 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock July 24, 2025 03:50 — with GitHub Actions Inactive
@jinge90
address review comments
cefd92a 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 requested a review from a team July 24, 2025 08:42
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 24, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@steffenlarsen steffenlarsen merged commit a071554 into intel:sycl Jul 24, 2025
25 checks passed
@jinge90 jinge90 deleted the add_strlen_strcmp_to_libdevice branch July 24, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinge90 @maarquitos14 @steffenlarsen