[SYCL][Unit] Fix unit-tests after intel/llvm#19399 #19543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#19399 made layout of `scheduler` class dependent on whether or not XPTI instrumentation is enabled. This caused issues with layout mismatch when `scheduler.hpp` is included directly from unit-tests, because macro enabling XPTI were not aligned between the RT and unit-tests. The issue was caught for scheduler unit-tests and fixed in intel#19399, but apparently we have more unit-tests which need scheduler. Internal testing discovered issues with buffer unit-tests. Therefore, re-applied the fix from intel#19399 globally to all unit-tests to prevent issues like this appearing in new and other existing unit-tests.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Jul 22, 2025
|
E2E tests in pre-commit failed due to infra issues (unable to get a toolchain from the artifacts). This patch does not affect E2E tests, so I will proceed with merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19399 made layout of
schedulerclass dependent on whether or not XPTI instrumentation is enabled. This caused issues with layout mismatch whenscheduler.hppis included directly from unit-tests, because macro enabling XPTI were not aligned between the RT and unit-tests.The issue was caught for scheduler unit-tests and fixed in #19399, but apparently we have more unit-tests which need scheduler. Internal testing discovered issues with buffer unit-tests.
Therefore, re-applied the fix from #19399 globally to all unit-tests to prevent issues like this appearing in new and other existing unit-tests.