[SYCL][ESIMD] Run all passes with O0 opt level #19554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sarnex
approved these changes
Jul 22, 2025
| @@ -177,6 +177,10 @@ cl::opt<bool> OptLevelO3("O3", | |||
| cl::desc("Optimization level 3. Similar to clang -O3"), | |||
| cl::cat(PostLinkCat)); | |||
|
|
|||
| cl::opt<bool> ForceDisableOpt("force-disable-opt", | |||
| cl::desc("Force no optimizations."), | |||
Exactly, I reverted the two PRs we merged before, so they were back to their original state, and now only added the new option. |
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sarnex
reviewed
Jul 22, 2025
| @@ -177,6 +177,10 @@ cl::opt<bool> OptLevelO3("O3", | |||
| cl::desc("Optimization level 3. Similar to clang -O3"), | |||
| cl::cat(PostLinkCat)); | |||
|
|
|||
| cl::opt<bool> ForceDisableOpt("force-disable-opt", cl::Hidden, | |||
There was a problem hiding this comment.
sorry since its only used for ESIMD can we call it like force-disable-esimd-opt?
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19411, we simply went for running all passes regardless of the optimization level. However, the change made it quite difficult to test a lot of the ESIMD functionalities, and some tests were even useless after the change. #19411 --and it's follow up #19453, is now reverted, and we're taking a new approach: we still run all passes with
-O0, but we add a new-force-disable-optoption tosycl-post-linkso we can still test for ESIMD functionalities and keep the tests valid.