[NFC][UR][L0] Eliminate code duplication in kernel launch logic #19562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes duplicated code between regular and cooperative kernel launches. The only actual difference between these paths is the use of either `zeCommandListAppendLaunchKernel` or `zeCommandListAppendLaunchCooperativeKernel`. This simplifies maintenance by consolidating identical code and reduces the risk of divergence.
pbalcer
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
@againull likely this patch broke sycl_cts/test_spec_constants on Win & L0 gen12 - https://github.com/intel/llvm/actions/runs/16535612020/job/46770595067
SYCL exception
with category name: 'sycl'
with code: 'invalid'
with code raw value: '8'
with code message: 'SYCL Error'
with what: 'Kernel is incompatible with all devices in devs'
Could you please check? In case this is the guilty one I suggest to temporarily revert if it's not possible to quickly fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes duplicated code between regular and cooperative kernel launches. The only actual difference between these paths is the use of either
zeCommandListAppendLaunchKernelorzeCommandListAppendLaunchCooperativeKernel.This simplifies maintenance by consolidating identical code and reduces the risk of divergence.