Skip to content

[DevTSAN] Move AllocInfo into DeviceInfo to support indirect access #19634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025

Conversation

zhaomaosu
Copy link
Contributor

@zhaomaosu zhaomaosu commented Jul 30, 2025

If we maintain AllocInfo in ContextInfo, this will cause the pointer which is allocated by another context can't be poisoned.

@zhaomaosu zhaomaosu requested a review from a team as a code owner July 30, 2025 02:07
@zhaomaosu zhaomaosu requested a review from a team July 30, 2025 03:26
@zhaomaosu zhaomaosu changed the title [DevTSAN] Release host allocated memory with correct API [DevTSAN] Move AllocInfo into DeviceInfo to support indirect access Jul 31, 2025
@zhaomaosu
Copy link
Contributor Author

Hi @intel/unified-runtime-reviewers, could you please help review this PR? Thanks.

@zhaomaosu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers, this PR is ready to be merge. Thanks.

@zhaomaosu
Copy link
Contributor Author

kindly ping @intel/llvm-gatekeepers

@ldrumm ldrumm merged commit f1017d0 into intel:sycl Aug 6, 2025
54 of 57 checks passed
@zhaomaosu zhaomaosu deleted the tsan-fix-buffer-free branch August 6, 2025 13:59
@ldrumm
Copy link
Contributor

ldrumm commented Aug 6, 2025

@sarnex The post commit testing here failed due to apparently missing Battlemage GPUs. Would you please take a look at those runners?

@sarnex
Copy link
Contributor

sarnex commented Aug 6, 2025

Taking a look now, thanks for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants