Revert "[UR][SYCL] Introduce UR api to set kernel args + launch in one call." #19661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e call. …" This reverts commit 24f54ea.
pbalcer
approved these changes
Jul 31, 2025
maarquitos14
approved these changes
Jul 31, 2025
aarongreig
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jchlanda
approved these changes
Aug 4, 2025
callumfare
approved these changes
Aug 4, 2025
uwedolinsky
approved these changes
Aug 4, 2025
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #18764
Looks like the naive level zero implementation now results in a performance regression, I think it's best to revert until l0 can better match the new interface.