-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL][E2E] Disable sporadically failing syclcompat tests #19682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@@ -31,6 +31,9 @@ | |||
// ===----------------------------------------------------------------------===// | |||
// RUN: %{build} -o %t.out | |||
// RUN: %{run} %t.out | |||
// | |||
// UNSUPPORTED: linux && run-mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead disable this test only for V2 L0 adapter? Because the failure seems to be only with the V2 L0 adapter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah nice thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @igchor recently added (or is adding) a LIT feature to detect that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in latest commit, thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @igchor recently added (or is adding) a LIT feature to detect that...
Yeah looks like its already there, called level_zero_v2_adapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -31,6 +31,9 @@ | |||
// ===----------------------------------------------------------------------===// | |||
// RUN: %{build} -o %t.out | |||
// RUN: %{run} %t.out | |||
// | |||
// UNSUPPORTED: linux && run-mode && level_zero_v2_adapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think level_zero_v2_adapter
is/should be a run-mode feature already, so run-mode
could probably be dropped. Minor and no updates are required though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill just fix it, thanks
Merging due to this failing for a ton of people. Happy to address comments post-merge @intel/syclcompat-lib-reviewers |
Issue: #19662