Skip to content

[SYCL][E2E] Disable sporadically failing syclcompat tests #19682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2025

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Aug 1, 2025

Issue: #19662

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review August 1, 2025 15:42
@sarnex sarnex requested a review from a team as a code owner August 1, 2025 15:42
@@ -31,6 +31,9 @@
// ===----------------------------------------------------------------------===//
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
// UNSUPPORTED: linux && run-mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead disable this test only for V2 L0 adapter? Because the failure seems to be only with the V2 L0 adapter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah nice thx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @igchor recently added (or is adding) a LIT feature to detect that...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in latest commit, thx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @igchor recently added (or is adding) a LIT feature to detect that...

Yeah looks like its already there, called level_zero_v2_adapter

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -31,6 +31,9 @@
// ===----------------------------------------------------------------------===//
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
// UNSUPPORTED: linux && run-mode && level_zero_v2_adapter
Copy link
Contributor

@aelovikov-intel aelovikov-intel Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think level_zero_v2_adapter is/should be a run-mode feature already, so run-mode could probably be dropped. Minor and no updates are required though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill just fix it, thanks

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex
Copy link
Contributor Author

sarnex commented Aug 1, 2025

Merging due to this failing for a ton of people. Happy to address comments post-merge @intel/syclcompat-lib-reviewers

@sarnex sarnex merged commit 11e7c4d into intel:sycl Aug 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants