[SYCL] Fix linkage adjustment of kernels #19771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves intel#19409 Two main changes were done: 1. Corrected method of detection that kernel is defined as an inline function. The original code detecting this was introduced in intel#338, but by some reason we looked into a headers-provided wrapper that calls a kernel instead of a kernel itself. Alongside with fixing this, a dedicated clang-level test was added to check this behavior 2. Fixed a bug introduced by incorrect conflict resolution (commit fcd95a9) with llvm/llvm-project#137882. Specifically, when deciding if a function (that is expected to be a SYCL kernel) linkage should be promoted to non-discardable we used to check for OpenCL kernel attribute. That attribute is not present in SYCL headers and therefore was only generated for actual SYCL kernels emitted by front-end. However, with kernel attributes unified, we now promote linkage of non-kernel wrapper function that has `sycl_kernel` attribute attached to it explicitly by SYCL headers. The fix here is to only react to the kernel attribute if it was added implicitly, to preserve original behavior.
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
reviewed
Aug 12, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
…kernel-linkage-adjustment
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Aug 12, 2025
| @@ -12824,7 +12824,8 @@ static GVALinkage adjustGVALinkageForAttributes(const ASTContext &Context, | |||
| if (Context.shouldExternalize(D)) | |||
| return GVA_StrongExternal; | |||
| } else if (Context.getLangOpts().SYCLIsDevice && | |||
| D->hasAttr<DeviceKernelAttr>()) { | |||
| (D->hasAttr<DeviceKernelAttr>() && | |||
There was a problem hiding this comment.
Lol sorry about all the problems caused from unifying the attributes, I originally just wanted to add a new attribute for SPIR kernels but upstream suggested I unify them all, thanks for fixing this
There was a problem hiding this comment.
To be fair, this whole thing with fixing-up the linkage is also a little bit weird, so no worries :)
Fznamznon
approved these changes
Aug 12, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tahonermann
reviewed
Aug 12, 2025
…kernel-linkage-adjustment
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Aug 13, 2025
YuriPlyakhin
approved these changes
Aug 13, 2025
AlexeySachkov
deleted the
private/asachkov/fix-kernel-linkage-adjustment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves #19409
Two main changes were done:
Corrected method of detection that kernel is defined as an inline function. The original code detecting this was introduced in [SYCL] Allow an inlined kernel to be called from multiple TUs. #338, but by some reason we looked into a headers-provided wrapper that calls a kernel instead of a kernel itself. Alongside with fixing this, a dedicated clang-level test was added to check this behavior
Fixed a bug introduced by incorrect conflict resolution (commit fcd95a9) with [clang] Simplify device kernel attributes llvm/llvm-project#137882. Specifically, when deciding if a function (that is expected to be a SYCL kernel) linkage should be promoted to non-discardable we used to check for OpenCL kernel attribute. That attribute is not present in SYCL headers and therefore was only generated for actual SYCL kernels emitted by front-end. However, with kernel attributes unified, we now promote linkage of non-kernel wrapper function that has
sycl_kernelattribute attached to it explicitly by SYCL headers. The fix here is to only react to the kernel attribute if it was added implicitly, to preserve original behavior.