[CI] Install DeviceConfigFile independently #19773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clear configure.py
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
approved these changes
Aug 12, 2025
sarnex
reviewed
Aug 12, 2025
| @@ -296,6 +296,7 @@ jobs: | |||
| cmake --build $GITHUB_WORKSPACE/build --target install-llvm-cov | |||
| cmake --build $GITHUB_WORKSPACE/build --target install-llvm-profdata | |||
| cmake --build $GITHUB_WORKSPACE/build --target install-compiler-rt | |||
| cmake --install $GITHUB_WORKSPACE/build --component DeviceConfigFile | |||
There was a problem hiding this comment.
basically we only install this file in CI now right?
There was a problem hiding this comment.
With this patch - yes. It's the initial intention as I understand:
https://github.com/intel/llvm/pull/16369/files#r1894476821
There was a problem hiding this comment.
I think this needs a comment in the code about what the file does and why we do it here.
There was a problem hiding this comment.
@aelovikov-intel does it answer the question? 0b66a95
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Aug 12, 2025
sarnex
approved these changes
Aug 12, 2025
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@sarnex @aelovikov-intel could you please merge |
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Aug 13, 2025
Also clear configure.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clear configure.py