Skip to content

[SYCL] Keep bfloat16 native and fallback spv for compatibility #19780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Aug 13, 2025

Previously, we stopped building and deploying native/fallback bfloat16 spv files since latest compiler will embed required files into user's executable. However, we found some developers hadn't switched to latest compiler, then compatibility issue would happen. This PR continues to build and deploy, we will remove the files util a marjor release.

@jinge90 jinge90 requested a review from a team as a code owner August 13, 2025 07:18
@jinge90
Copy link
Contributor Author

jinge90 commented Aug 13, 2025

Hi, @uditagarwal97
This PR continues to build and install bfloat16 spv, could you help review it?
Thanks very much.

Signed-off-by: jinge90 <ge.jin@intel.com>
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please also add a PR description about what the problem is.

@jinge90 jinge90 requested a review from a team August 14, 2025 03:25
@jinge90
Copy link
Contributor Author

jinge90 commented Aug 14, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@steffenlarsen steffenlarsen merged commit f6a74e2 into intel:sycl Aug 14, 2025
44 of 45 checks passed
@jinge90 jinge90 deleted the get_back_bfloat16_spv branch August 14, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants