[SYCL][Doc] Minor tweaks to SPV_INTEL_function_variants #19782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdnk
commented
Aug 13, 2025
jdnk
commented
- Fixes word count to match the consumer implementation
- Allows multiple OpConditionalCopyINTEL condition operands to be true. During specialization, the first operand whose condition is true is selected.
bashbaug
approved these changes
Aug 13, 2025
gmlueck
reviewed
Aug 14, 2025
| @@ -494,7 +494,7 @@ Add to Section 3.56.9, Function Instructions: | |||
| + | |||
| Make a copy of 'Operand X' if 'Condition X' is *true*. | |||
|
|
|||
| From all 'Condition X'-'Operand X' pairs, 'exactly' one 'Condition X' must be *true*. Consequently, at least one 'Condition X'-'Operand X' pair must be present. | |||
| From all 'Condition X'-'Operand X' pairs, at least one 'Condition X' must be *true*. Consequently, at least one 'Condition X'-'Operand X' pair must be present. | |||
There was a problem hiding this comment.
In the uses cases I can think of, setting more than one Condition X to true would indicate that something went wrong. What is the rationale for allowing this and arbitrarily using the first condition? Should we instead say this is not allowed and add a validation check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.