Skip to content

[UR][L0] Event cleanup in urEnqueueKernelLaunch #19827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2025
Merged

[UR][L0] Event cleanup in urEnqueueKernelLaunch #19827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4070f2a
[UR][L0] Event cleanup in urEnqueueKernelLaunch
winstonzhang-intel Aug 29, 2025
3b00c55
typo correction
winstonzhang-intel Sep 2, 2025
6680836
clang-format
winstonzhang-intel Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 40 additions & 5 deletions unified-runtime/source/adapters/level_zero/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ ur_result_t ur_context_handle_t_::getFreeSlotInExistingOrNewPool(
ze_event_pool_handle_t &Pool, size_t &Index, bool HostVisible,
bool ProfilingEnabled, ur_device_handle_t Device,
bool CounterBasedEventEnabled, bool UsingImmCmdList,
bool InterruptBasedEventEnabled) {
bool InterruptBasedEventEnabled, ur_queue_handle_t Queue, bool IsInternal) {

ze_device_handle_t ZeDevice = nullptr;
if (Device) {
Expand Down Expand Up @@ -461,8 +461,25 @@ ur_result_t ur_context_handle_t_::getFreeSlotInExistingOrNewPool(
});
}

ZE2UR_CALL(zeEventPoolCreate, (ZeContext, &ZeEventPoolDesc,
ZeDevices.size(), &ZeDevices[0], &Pool));
ze_result_t Result = ZE_CALL_NOCHECK(
zeEventPoolCreate,
(ZeContext, &ZeEventPoolDesc, ZeDevices.size(), &ZeDevices[0], &Pool));
if (IsInternal && ze2urResult(Result) == UR_RESULT_ERROR_OUT_OF_RESOURCES &&
Queue) {
if (!Queue->isInOrderQueue()) {
if (Queue->UsingImmCmdLists) {
UR_CALL(CleanupEventsInImmCmdLists(Queue, true /*QueueLocked*/,
false /*QueueSynced*/,
nullptr /*CompletedEvent*/));
} else {
UR_CALL(resetCommandLists(Queue));
}
ZE2UR_CALL(zeEventPoolCreate, (ZeContext, &ZeEventPoolDesc,
ZeDevices.size(), &ZeDevices[0], &Pool));
}
} else if (ze2urResult(Result) != UR_RESULT_SUCCESS) {
return ze2urResult(Result);
}
Index = 0;
NumEventsAvailableInEventPool[Pool] = MaxNumEventsPerPool - 1;
NumEventsUnreleasedInEventPool[Pool] = 1;
Expand Down Expand Up @@ -546,8 +563,26 @@ ur_result_t ur_context_handle_t_::getFreeSlotInExistingOrNewPool(
});
}

ZE2UR_CALL(zeEventPoolCreate, (ZeContext, &ZeEventPoolDesc,
ZeDevices.size(), &ZeDevices[0], ZePool));
ze_result_t Result = ZE_CALL_NOCHECK(
zeEventPoolCreate,
(ZeContext, &ZeEventPoolDesc, ZeDevices.size(), &ZeDevices[0], ZePool));
if (IsInternal && ze2urResult(Result) == UR_RESULT_ERROR_OUT_OF_RESOURCES &&
Queue) {
if (!Queue->isInOrderQueue()) {
if (Queue->UsingImmCmdLists) {
UR_CALL(CleanupEventsInImmCmdLists(Queue, true /*QueueLocked*/,
false /*QueueSynced*/,
nullptr /*CompletedEvent*/));
} else {
UR_CALL(resetCommandLists(Queue));
}
ZE2UR_CALL(zeEventPoolCreate,
(ZeContext, &ZeEventPoolDesc, ZeDevices.size(),
&ZeDevices[0], ZePool));
}
} else if (ze2urResult(Result) != UR_RESULT_SUCCESS) {
return ze2urResult(Result);
}
NumEventsAvailableInEventPool[*ZePool] = MaxNumEventsPerPool - 1;
NumEventsUnreleasedInEventPool[*ZePool] = 1;
} else {
Expand Down
13 changes: 6 additions & 7 deletions unified-runtime/source/adapters/level_zero/context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,13 +202,12 @@ struct ur_context_handle_t_ : ur_object {
// pool then create new one. The HostVisible parameter tells if we need a
// slot for a host-visible event. The ProfilingEnabled tells is we need a
// slot for an event with profiling capabilities.
ur_result_t getFreeSlotInExistingOrNewPool(ze_event_pool_handle_t &, size_t &,
bool HostVisible,
bool ProfilingEnabled,
ur_device_handle_t Device,
bool CounterBasedEventEnabled,
bool UsingImmCmdList,
bool InterruptBasedEventEnabled);
ur_result_t getFreeSlotInExistingOrNewPool(
ze_event_pool_handle_t &, size_t &, bool HostVisible,
bool ProfilingEnabled, ur_device_handle_t Device,
bool CounterBasedEventEnabled, bool UsingImmCmdList,
bool InterruptBasedEventEnabled, ur_queue_handle_t Queue,
bool IsInternal);

// Get ur_event_handle_t from cache.
ur_event_handle_t getEventFromContextCache(bool HostVisible,
Expand Down
16 changes: 9 additions & 7 deletions unified-runtime/source/adapters/level_zero/event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,16 +1349,18 @@ ur_result_t CleanupCompletedEvent(ur_event_handle_t Event, bool QueueLocked,
// The "HostVisible" argument specifies if event needs to be allocated from
// a host-visible pool.
//
ur_result_t EventCreate(ur_context_handle_t Context, ur_queue_handle_t Queue,
bool IsMultiDevice, bool HostVisible,
ur_event_handle_t *RetEvent,
bool CounterBasedEventEnabled,
bool ForceDisableProfiling,
bool InterruptBasedEventEnabled) {
ur_result_t
EventCreate(ur_context_handle_t Context, ur_queue_handle_t Queue,
bool IsMultiDevice, bool HostVisible, ur_event_handle_t *RetEvent,
bool CounterBasedEventEnabled, bool ForceDisableProfiling,
bool InterruptBasedEventEnabled, std::optional<bool> IsInternal) {
bool ProfilingEnabled =
ForceDisableProfiling ? false : (!Queue || Queue->isProfilingEnabled());
bool UsingImmediateCommandlists = !Queue || Queue->UsingImmCmdLists;

// Handle optional IsInternal parameter - default to false if not provided
bool isInternalValue = IsInternal.value_or(false);

ur_device_handle_t Device = nullptr;

if (!IsMultiDevice && Queue) {
Expand All @@ -1380,7 +1382,7 @@ ur_result_t EventCreate(ur_context_handle_t Context, ur_queue_handle_t Queue,
if (auto Res = Context->getFreeSlotInExistingOrNewPool(
ZeEventPool, Index, HostVisible, ProfilingEnabled, Device,
CounterBasedEventEnabled, UsingImmediateCommandlists,
InterruptBasedEventEnabled))
InterruptBasedEventEnabled, Queue, isInternalValue))
return Res;

ZeStruct<ze_event_desc_t> ZeEventDesc;
Expand Down
3 changes: 2 additions & 1 deletion unified-runtime/source/adapters/level_zero/event.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ ur_result_t EventCreate(ur_context_handle_t Context, ur_queue_handle_t Queue,
ur_event_handle_t *RetEvent,
bool CounterBasedEventEnabled,
bool ForceDisableProfiling,
bool InterruptBasedEventEnabled);
bool InterruptBasedEventEnabled,
std::optional<bool> IsInternal = std::nullopt);
} // extern "C"

// This is an experimental option that allows to disable caching of events in
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/source/adapters/level_zero/queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,7 @@ ur_result_t createEventAndAssociateQueue(ur_queue_handle_t Queue,
UR_CALL(EventCreate(
Queue->Context, Queue, IsMultiDevice, HostVisible.value(), Event,
Queue->CounterBasedEventsEnabled, false /*ForceDisableProfiling*/,
Queue->InterruptBasedEventsEnabled));
Queue->InterruptBasedEventsEnabled, IsInternal));

(*Event)->UrQueue = Queue;
(*Event)->CommandType = CommandType;
Expand Down
Loading