[UR][Offload] Fixes for enqueue UR CTS tests #19926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Sep 1, 2025
| PlatformName.data(), nullptr); | ||
| if (strcmp(PlatformName.data(), "CUDA") == 0) { | ||
| triple = "nvptx64-nvidia-cuda"; | ||
| } else if (strcmp(PlatformName.data(), "AMDGPU") == 0) { |
There was a problem hiding this comment.
don't love the use of strcmp but I do recognize that this is moved, not new
aarongreig
approved these changes
Sep 1, 2025
A small selection of fixes to increase the pass rate of the enqueue CTS unit tests: * Blocking memory reads/writes now properly wait on the queue. * `urKernelSetArgMemObj` added to the function table. * Debug print removed. * Layout of kernel arguments now matches the HIP target if Offload is on an AMD device. * `urEnqueueEventsWaitWithBarrierExt` has been implemented (it just calls to the non-ext version). * `UR_DEVICE_INFO_TIMESTAMP_RECORDING_SUPPORT_EXP` set to false.
RossBrunton
force-pushed
the
enqueueFixes
branch
from
9ba4791 to
048d0eb
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers I think this is ready to merge. The failure in L0 is unrelated, as this code doesn't touch cmake and this failure affects other commits ( intel/llvm/actions/runs/17310765995/job/49144828656?pr=19921 ). EDIT: #19944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small selection of fixes to increase the pass rate of the enqueue CTS
unit tests:
urKernelSetArgMemObjadded to the function table.an AMD device.
urEnqueueEventsWaitWithBarrierExthas been implemented (it justcalls to the non-ext version).
UR_DEVICE_INFO_TIMESTAMP_RECORDING_SUPPORT_EXPset to false.