Skip to content

Conversation

coldav
Copy link
Contributor

@coldav coldav commented Sep 3, 2025

The Native CPU work is being passed onto a team in Intel now that
all of Native CPU is independent of the oneAPI Construction Kit.

Native CPU does not pass all of E2E testing, either through bugs or
unimplemented functionality. Most are currently being marked as
UNSUPPORTED until these failures are processed and tracked by the new
team, with a smaller number marked as XFAIL. These are being tracked under #20142.

This also adds a separate job for E2E build and run for Native CPU,
as it cannot be added to the prebuilt due to build fails.

@coldav coldav requested a review from a team as a code owner September 3, 2025 15:56
@coldav coldav force-pushed the colin/add_sycl_e2e_native_cpu branch from bb77a72 to 991d38e Compare September 3, 2025 15:57
@coldav coldav force-pushed the colin/add_sycl_e2e_native_cpu branch 6 times, most recently from 7a79656 to 918523a Compare September 16, 2025 10:07
@coldav coldav requested review from a team as code owners September 16, 2025 10:07
@AlexeySachkov AlexeySachkov marked this pull request as draft September 16, 2025 10:10
@coldav coldav force-pushed the colin/add_sycl_e2e_native_cpu branch from 918523a to 3ea3d02 Compare September 16, 2025 11:35
@coldav coldav force-pushed the colin/add_sycl_e2e_native_cpu branch from 3ea3d02 to 95496d2 Compare September 16, 2025 13:46
@coldav coldav force-pushed the colin/add_sycl_e2e_native_cpu branch from 95496d2 to 2756583 Compare September 16, 2025 14:48
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coldav
Copy link
Contributor Author

coldav commented Sep 23, 2025

@intel/dpcpp-sanitizers-review @intel/dpcpp-esimd-reviewers @intel/unified-runtime-reviewers-level-zero @intel/unified-runtime-reviewers I am running out of time for this to be reviewed.

hvdijk added a commit to hvdijk/dpcppllvm that referenced this pull request Sep 23, 2025
@coldav
Copy link
Contributor Author

coldav commented Sep 23, 2025

@intel/dpcpp-sanitizers-review @intel/dpcpp-esimd-reviewers if you have the spare capacity tomorrow (Wed) to review it would be very much appreciated.

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esimd lgtm

The Native CPU work is being passed onto a team in Intel now that
all of Native CPU is independent of the oneAPI Construction Kit.

Native CPU does not pass all of E2E testing, either through bugs or
unimplemented functionality. All are currently being marked as
UNSUPPORTED until these failures are processed and tracked by the new
team.

This also adds a separate job for E2E build and run for Native CPU,
as it cannot be added to the prebuilt due to build fails.
@coldav
Copy link
Contributor Author

coldav commented Sep 24, 2025

@intel/llvm-gatekeepers Is it possible to merge this, I've got 4 approvals and the only reason for the sanitizer one is to add some UNSUPPORTED across the sanitizers. There is increasingly limited time and there is a dependent PR.
Note the failure seems unrelated and is a timeout on a job, which i've seen twice now and on other PRs. This passed last night before I rebased this morning https://github.com/intel/llvm/actions/runs/17951937108.

@steffenlarsen
Copy link
Contributor

Reran it again and it turned green. Probably just infrastructural.

I am going to make the executive decision to merge this. @intel/dpcpp-sanitizers-review - Feel free to do a post-commit review and we can address them in a follow-up.

@steffenlarsen steffenlarsen merged commit 6b29cf1 into intel:sycl Sep 24, 2025
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants