[SYCL] Represent the half as __fp16 to follow OpenCL representation. #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__fp16 is the type used to represent half type. It lowers to the same type as would _Float16 if the target support native half but doesn't requires that the target/backend support it to use it. Signed-off-by: Victor Lomuller <victor@codeplay.com>
bader
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussed in the upstreaming call, this is the changes identified to align the half type with the OpenCL one.
__fp16 is the type used to represent half type.
It lowers to the same type as would _Float16 if the target support native half
but doesn't requires that the target/backend support it to use it.
Signed-off-by: Victor Lomuller victor@codeplay.com