Skip to content

[NFCI][SYCL] Reduce dependencies of <sycl/item.hpp> #20048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

[NFCI][SYCL] Reduce dependencies of <sycl/item.hpp> #20048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sycl/include/sycl/item.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@

#include <sycl/detail/defines.hpp> // for __SYCL_ASSUME_INT
#include <sycl/detail/defines_elementary.hpp> // for __SYCL_ALWAYS_INLINE, __SYC...
#include <sycl/detail/helpers.hpp> // for Builder
#include <sycl/detail/item_base.hpp> // for id, range, ItemBase
#include <sycl/exception.hpp> // for make_error_code, errc, exce...
#include <sycl/id.hpp> // for id, item
#include <sycl/range.hpp> // for range

Expand Down Expand Up @@ -93,8 +91,7 @@ template <int Dimensions = 1, bool with_offset = true> class item {

template <bool has_offset = with_offset>
operator std::enable_if_t<!has_offset, item<Dimensions, true>>() const {
return detail::Builder::createItem<Dimensions, true>(
MImpl.MExtent, MImpl.MIndex, /*Offset*/ {});
return item<Dimensions, true>{MImpl.MExtent, MImpl.MIndex, /*Offset*/ {}};
}

size_t __SYCL_ALWAYS_INLINE get_linear_id() const {
Expand Down Expand Up @@ -128,6 +125,8 @@ template <int Dimensions = 1, bool with_offset = true> class item {

friend class detail::Builder;

template <int, bool> friend class item;

private:
detail::ItemBase<Dimensions, with_offset> MImpl;
};
Expand Down