Skip to content

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Sep 12, 2025

Similar to #20049

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new forward declaration header sycl/detail/fwd/accessor.hpp to centralize accessor-related forward declarations and eliminates redundant forward declarations throughout the codebase.

  • Consolidates all accessor forward declarations into a single header file
  • Removes duplicate forward declarations from multiple files
  • Updates include dependency tests to reflect the new include structure

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sycl/include/sycl/detail/fwd/accessor.hpp Creates new header with consolidated accessor forward declarations
sycl/include/sycl/accessor.hpp Removes redundant forward declaration and adds default template parameters
sycl/include/sycl/buffer.hpp Removes local forward declaration, includes new header
sycl/include/sycl/handler.hpp Removes redundant image_accessor forward declaration
sycl/include/sycl/image.hpp Removes multiple accessor forward declarations
sycl/include/sycl/multi_ptr.hpp Removes local accessor forward declarations
sycl/include/sycl/sampler.hpp Removes image_accessor forward declaration
sycl/include/sycl/properties/accessor_properties.hpp Removes extensive accessor forward declarations
sycl/include/sycl/ext/oneapi/accessor_property_list.hpp Removes accessor forward declaration
sycl/include/sycl/detail/accessor_iterator.hpp Removes accessor forward declaration
sycl/test/include_deps/sycl_*.cpp Updates test expectations for new include order

@aelovikov-intel aelovikov-intel merged commit 47c19c9 into intel:sycl Sep 12, 2025
30 of 32 checks passed
@aelovikov-intel aelovikov-intel deleted the fwd-accessor branch September 12, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants