Skip to content

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Sep 12, 2025

Spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_clock.asciidoc

The test for this exists, but isn't being tested due to issues down the stack, see #20100.

@KornevNikita
Copy link
Contributor Author

@intel/unified-runtime-reviewers-level-zero hi guys, could you please help to figure out how to check if this feature supported by a L0-device? IGC supports it already, but I don't know if there are any restrictions from the L0 side. Should I just somehow check the version of IGC?

@aelovikov-intel
Copy link
Contributor

I've updated the description, please check if that was accurate.

@KornevNikita
Copy link
Contributor Author

@intel/unified-runtime-reviewers @intel/unified-runtime-reviewers-opencl take a look please

@pbalcer
Copy link
Contributor

pbalcer commented Sep 18, 2025

@intel/unified-runtime-reviewers-level-zero hi guys, could you please help to figure out how to check if this feature supported by a L0-device? IGC supports it already, but I don't know if there are any restrictions from the L0 side. Should I just somehow check the version of IGC?

I don't believe there's an API in L0 to check this. At least I'm not aware of one. @nrspruit do you know? Checking IGC/driver version should be the last resort, but we already have hacks like that in place:

bool isDriverVersionNewerOrSimilar(uint32_t VersionMajor,
uint32_t VersionMinor,
uint32_t VersionBuild);

So, for now, if IGC supports this unconditionally on all supported platforms, you could simply return true on driver versions that contain the required IGC.

Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@KornevNikita
Copy link
Contributor Author

@intel/llvm-gatekeepers yep, this one is ready, I will add the L0-part with a separate patch. Please merge.

@steffenlarsen steffenlarsen merged commit 3274ca1 into intel:sycl Sep 18, 2025
68 of 71 checks passed
KornevNikita added a commit to KornevNikita/llvm that referenced this pull request Sep 18, 2025
uditagarwal97 pushed a commit that referenced this pull request Sep 19, 2025
github-actions bot pushed a commit to oneapi-src/unified-runtime that referenced this pull request Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants