-
Notifications
You must be signed in to change notification settings - Fork 806
[SYCL] Fix for sycl::detail::string and tests #20076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Fix for sycl::detail::string and tests #20076
Conversation
gentle ping @sergey-semenov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this didn't fall apart earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks.
TEST_F(SYCLDetailStringTest, Swap) { | ||
sycl::detail::string s1("first"); | ||
sycl::detail::string s2("second"); | ||
swap(s1, s2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to your PR, but I don't get why we define swap
instead of a std::swap
overload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(dunno) emoji
how have we made it this far?