[SYCL][Native CPU] More --shared-libs fixes. #20081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SYCLNativeCPUUtils/CMakeLists.txt: remove EXCLUDE_FROM_ALL. The rationale for setting EXCLUDE_FROM_ALL was to ensure that users do not get the veczc binary unnecessarily but that is already handled differently now that we no longer fetch external sources, and EXCLUDE_FROM_ALL had the side effect of preventing component libraries from being installed. * vecz/tools/CMakeLists.txt: change veczc from tool to utility. The difference is that tools get installed, utilities by default don't, and this is not something that is meant to be installed. * lib/CMakeLists.txt: change include order. SYCLNativeCPUUtils needs to be included after TargetParser so that veczc correctly links to it. Fixes intel#20077
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
approved these changes
Sep 15, 2025
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Sep 15, 2025
|
Thanks, in that case this is ready to be merged @intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20077