Skip to content

Conversation

dm-vodopyanov
Copy link
Contributor

No description provided.

@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner September 15, 2025 13:01
@dm-vodopyanov dm-vodopyanov changed the title [SYCL][Doc] Add is_gpu_integrated query to sycl_ext_intel_device_info [SYCL][Doc] Add sycl_ext_oneapi_device_is_integrated spec extension Sep 15, 2025
@aelovikov-intel
Copy link
Contributor

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that an earlier version of this PR added the query to sycl_ext_intel_device_info. Why did you change your mind and add it as a separate extension?

If we need to add this query as both an info descriptor and also an aspect (telling whether the info descriptor is supported), then it might be better to add it to sycl_ext_intel_device_info because it matches the pattern we use there.

== Overview

This extension allows host code to check whether a physical device, represented
by a SYCL device, is integrated with the host.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest a slight rewording here because the difference between "integrated" and "discrete" isn't always clear cut:

This extension allows host code to check whether a SYCL GPU device is "integrated" or "discrete". An integrated GPU device often shares memory with the host CPU, while a discrete GPU is often a separate card with its own memory. However, some GPU devices may not fit neatly into either category, so implementors may provide their own judgement when categorizing a GPU device as "integrated" vs. "discrete".

@bashbaug does this seem like a reasonable description? Any suggestions?

@dm-vodopyanov dm-vodopyanov requested a review from gmlueck October 2, 2025 14:33
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Oct 2, 2025

@intel/llvm-gatekeepers please consider merging

@steffenlarsen steffenlarsen merged commit dfc06dd into intel:sycl Oct 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants