Skip to content

[NFC][SYCL] Reduce dependencies of <sycl/group.hpp> #20090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

[NFC][SYCL] Reduce dependencies of <sycl/group.hpp> #20090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sycl/include/sycl/detail/fwd/multi_ptr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@ inline namespace _V1 {
template <typename ElementType, access::address_space Space,
access::decorated DecorateAddress>
class multi_ptr;
template <access::address_space Space, access::decorated DecorateAddress,
typename ElementType>
multi_ptr<ElementType, Space, DecorateAddress>
address_space_cast(ElementType *pointer);
} // namespace _V1
} // namespace sycl
26 changes: 14 additions & 12 deletions sycl/include/sycl/group.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,37 @@

#pragma once

#include <sycl/__spirv/spirv_types.hpp> // for Scope, __ocl_event_t
#include <sycl/access/access.hpp> // for decorated, mode, addr...
#include <sycl/detail/common.hpp> // for NDLoop, __SYCL_ASSERT
#include <sycl/detail/defines.hpp> // for __SYCL_TYPE
#include <sycl/detail/defines_elementary.hpp> // for __SYCL2020_DEPRECATED
#include <sycl/__spirv/spirv_types.hpp> // for Scope, __ocl_event_t
#include <sycl/access/access.hpp> // for decorated, mode, addr...
#include <sycl/detail/common.hpp> // for NDLoop
#include <sycl/detail/defines.hpp> // for __SYCL_TYPE
#include <sycl/detail/defines_elementary.hpp> // for __SYCL2020_DEPRECATED
#include <sycl/detail/fwd/multi_ptr.hpp>
#include <sycl/detail/generic_type_traits.hpp> // for convertToOpenCLType
#include <sycl/detail/helpers.hpp> // for Builder, getSPIRVMemo...
#include <sycl/detail/item_base.hpp> // for id, range
#include <sycl/detail/type_traits.hpp> // for is_bool, change_base_...
#include <sycl/device_event.hpp> // for device_event
#include <sycl/exception.hpp> // for make_error_code, errc
#include <sycl/h_item.hpp> // for h_item
#include <sycl/id.hpp> // for id
#include <sycl/item.hpp> // for item
#include <sycl/memory_enums.hpp> // for memory_scope
#include <sycl/multi_ptr.hpp> // for multi_ptr, address_sp...
#include <sycl/pointers.hpp> // for decorated_global_ptr
#include <sycl/range.hpp> // for range

#include <memory> // for unique_ptr
#ifndef __SYCL_DEVICE_ONLY__
#include <sycl/exception.hpp>

#include <memory> // for unique_ptr
#endif

#include <stddef.h> // for size_t
#include <stdint.h> // for uint8_t, uint32_t
#include <type_traits> // for enable_if_t, remove_c...

namespace sycl {
inline namespace _V1 {
namespace detail {
class Builder;
template <int Dimensions> class h_item;

namespace detail {
// Implements a barrier accross work items within a work group.
inline void workGroupBarrier() {
#ifdef __SYCL_DEVICE_ONLY__
Expand Down
2 changes: 1 addition & 1 deletion sycl/test/include_deps/sycl_detail_core.hpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@
// CHECK-NEXT: detail/kernel_desc.hpp
// CHECK-NEXT: group.hpp
// CHECK-NEXT: device_event.hpp
// CHECK-NEXT: h_item.hpp
// CHECK-NEXT: item.hpp
// CHECK-NEXT: h_item.hpp
// CHECK-NEXT: kernel_handler.hpp
// CHECK-NEXT: nd_item.hpp
// CHECK-NEXT: nd_range.hpp
Expand Down