[SYCL] Fix sampled bindless fetch_image for float type
#20107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Sep 17, 2025
| // fetch_image should not use the sampler | ||
| if constexpr (detail::is_recognized_standard_type<DataT>()) { | ||
| return FETCH_SAMPLED_IMAGE( | ||
| return FETCH_UNSAMPLED_IMAGE( |
There was a problem hiding this comment.
Side note:
- Some of these macros seem a little unnecessary, i.e. some of the just wrap the same function in all paths, which is in turn no longer than the macro itself.
- The macros bleed into user-space, i.e. we don't undef them at the end of the header. We should probably address that. Maybe we should move away from macros and use inline or anonymous functions instead?
Would you mind opening a follow-up fix for this and/or open an issue?
|
@intel/llvm-gatekeepers please consider merging |
YixingZhang007
pushed a commit
to YixingZhang007/llvm
that referenced
this pull request
Sep 22, 2025
The implementation previously used `__spirv_ImageSampleExplicitLod` which returned incorrect results when the `DataT` return type was a vector of floats. This change makes it use `__spirv_ImageRead` instead and adds a test case for the `float` image type. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation previously used
__spirv_ImageSampleExplicitLodwhich returned incorrect results when theDataTreturn type was a vector of floats. This change makes it use__spirv_ImageReadinstead and adds a test case for thefloatimage type.