Skip to content

[SYCL] Remove fpga related Assert tests #20108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

[SYCL] Remove fpga related Assert tests #20108

merged 1 commit into from
Sep 17, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Sep 17, 2025

No description provided.

@jinge90 jinge90 requested a review from a team as a code owner September 17, 2025 03:19
@jinge90
[SYCL] Remove fpga related Assert tests
e3ac869 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author

jinge90 commented Sep 17, 2025

Hi, @steffenlarsen
I see #18310 has been merged last week, fallback assert is removed from sycl. So, it seems to make sense to clear all fpga related assert tests since native assert was not supported for fpga platform, the tests suppose fpga still uses fallback assert and expected different behavior from gpu, cpu devices.
Thanks very much.

@steffenlarsen steffenlarsen merged commit ad08ff2 into intel:sycl Sep 17, 2025
28 checks passed
YixingZhang007 pushed a commit to YixingZhang007/llvm that referenced this pull request Sep 22, 2025
@jinge90 @YixingZhang007
[SYCL] Remove fpga related Assert tests (intel#20108)
8f2fb7a 
Signed-off-by: jinge90 <ge.jin@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97 uditagarwal97 is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jinge90 @steffenlarsen