[UR] Improve handling for devices/platforms that don't support images #20128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
xfailimage
branch
from
99411c2 to
a7021bc
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Image support is optional and depends on UR_DEVICE_INFO_IMAGE_SUPPORT. Now, entrypoints that involve images should return UNSUPPORTED_FEATURE if image support is unavailable. The offload plugin now defines image functions as stubs that return this "UNSUPPORTED_FEATURE" value. CTS testing is more rebust. Support for images is now checked before trying to load the kernel binary, since that binary will not be available for platforms that don't support images.
RossBrunton
force-pushed
the
xfailimage
branch
from
a7021bc to
d583e2f
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Sep 19, 2025
|
@intel/llvm-gatekeepers Please merge. |
YixingZhang007
pushed a commit
to YixingZhang007/llvm
that referenced
this pull request
Sep 22, 2025
…intel#20128) Image support is optional and depends on UR_DEVICE_INFO_IMAGE_SUPPORT. Now, entrypoints that involve images should return UNSUPPORTED_FEATURE if image support is unavailable. The offload plugin now defines image functions as stubs that return this "UNSUPPORTED_FEATURE" value. CTS testing is more rebust. Support for images is now checked before trying to load the kernel binary, since that binary will not be available for platforms that don't support images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image support is optional and depends on UR_DEVICE_INFO_IMAGE_SUPPORT.
Now, entrypoints that involve images should return UNSUPPORTED_FEATURE
if image support is unavailable.
The offload plugin now defines image functions as stubs that return this
"UNSUPPORTED_FEATURE" value.
CTS testing is more rebust. Support for images is now checked before
trying to load the kernel binary, since that binary will not be
available for platforms that don't support images.