[UR] better assertions #20169
Open
[UR] better assertions #20169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lslusarczyk
commented
Sep 23, 2025
lslusarczyk
commented
- added printing backtrace to assertions
- added debug and production assertions that break code immediately instead of throwing exception
- asserting code immediately instead of throwing exception in debug mode for faster development
- uninlining create_logger function
- moved backtrace code from validation layer to common code
lslusarczyk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kswiecicki
reviewed
Sep 23, 2025
| default: | ||
| throw UR_RESULT_ERROR_INVALID_ARGUMENT; | ||
| case UR_USM_TYPE_UNKNOWN: | ||
| case UR_USM_TYPE_FORCE_UINT32:; // silence warning, fail below |
There was a problem hiding this comment.
nit: If you were to leave the default case and call UR_FFAILURE there, wouldn't the warning disappear?
There was a problem hiding this comment.
removing default and having all cases listed explicitly makes this code to produce warning when someone will add a new enum and forget to change this switch
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.