Skip to content

[SYCL] Cleanup getNative symbols in API/ABI #20170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2025
Merged

[SYCL] Cleanup getNative symbols in API/ABI #20170

merged 3 commits into from
Sep 23, 2025
+25 −2

Conversation

AlexeySachkov
Copy link
Contributor

@AlexeySachkov AlexeySachkov commented Sep 23, 2025 •
edited
Loading

  • Dropped kernel::getNativeImpl under preview breaking changes;
  • Deprecated queue::getNative and made it private under preview breaking changes;
  • Made device_image::getNative private.

@AlexeySachkov
[SYCL] Cleanup getNative symbols in API/ABI
91f6bca 
Dropped `kernel::getNativeImpl` under preview breaking changes.
Deprecated `queue::getNative` and made it private under preview breaking
changes.
Made `device_image::getNative` private.
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner September 23, 2025 13:33
@AlexeySachkov
Copy link
Contributor Author 

# | There are missing symbols in the new library. It is a breaking change. Refer to sycl/doc/developer/ABIPolicyGuide.md for further instructions. Do not forget to update ABI version according to the policy.
# | The following symbols are missing from the new object file:
# | 
# | ?getNative@device_image_plain@detail@_V1@sycl@@QEBA_KXZ
# | There are new symbols in the new library. It is a non-breaking change. Refer to sycl/doc/developer/ABIPolicyGuide.md for further instructions.
# | The following symbols are new to the object file:
# | 
# | ?getNative@device_image_plain@detail@_V1@sycl@@IEBA_KXZ

Ugh, access specifiers are a part of the mangling on Windows, apparently

@AlexeySachkov AlexeySachkov merged commit b68db56 into intel:sycl Sep 23, 2025
27 checks passed
@AlexeySachkov AlexeySachkov deleted the private/asachkov/getNative-cleanup branch September 23, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeySachkov @uditagarwal97