[SYCL] Add layout test for the CompileTimeKernelInfoTy #20200
Conversation
vinser52
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-runtime, PR is ready for review. |
|
@intel/llvm-gatekeepers PR is ready for merge |
| @@ -0,0 +1,26 @@ | |||
| // RUN: %clangxx -fsycl -c -fno-color-diagnostics -Xclang -fdump-record-layouts %s -o %t.out | FileCheck %s | |||
| // REQUIRES: linux | |||
| // UNSUPPORTED: libcxx | |||
There was a problem hiding this comment.
I take that line from other layout tests. I guess it is a common restriction, but I have not verified by myself.
There was a problem hiding this comment.
As I understood, #2731 disables all ABI tests with libcxx.
There was a problem hiding this comment.
Huh, that's quite old one and Nick had to fix the build since then. I think that PR disabled the tests because those classes were using std::something as members, which is not the case for CompileTimeKernelInfoTy. However, if other classes don't run, then there is little value in testing this one.
There was a problem hiding this comment.
I didn't investigate anything but in general the libcxx abi is totally different than libstdc++ (like the names of all the internal data structures), so we would need to write a seperate test for libcxx, but just disabling it is fine since the libstdc++ version should catch any problems.
|
@intel/llvm-gatekeepers please consider merging |
4 participants
No description provided.