[SYCL] Add template parameter support for num_simd_work_items attribute #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch 1. adds support for template parameter on [[intelfpga::num_simd_work_items()]] attribute 2. splits test/SemaSYCL/num_simd_work_items.cpp to separate files for host compilation (test/SemaSYCL/num_simd_work_items_host.cpp) and device compilation (test/SemaSYCL/num_simd_work_items_device.cpp) 3. makes changes to intel_reqd_sub_group_size attribute source codes to avoid duplication and reuse for the template parameter support. Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
MrSidims
reviewed
Sep 22, 2020
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
erichkeane
reviewed
Sep 22, 2020
premanandrao
previously approved these changes
Sep 22, 2020
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
dismissed stale reviews from premanandrao and MrSidims
via
533d9a1
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
erichkeane
reviewed
Sep 22, 2020
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
erichkeane
approved these changes
Sep 22, 2020
premanandrao
approved these changes
Sep 22, 2020
|
Thank you, everyone for the reviews. |
smanna12
added a commit
to smanna12/llvm
that referenced
this pull request
Jan 25, 2021
Template parameter support was added for 1. [[intel::max_global_work_dim)]] attribute on intel#2816 2. [[intel::num_simd_work_items()]] attribute on intel#2510 3. [[intel::reqd_sub_group_size()]] attribute on intel#1807 This patch adds the following new test cases that were not there before to improve the support: 1. Test that checks wrong function template instantiation and ensures that the type is checked properly when instantiating from the template definition. 2. Test that checks expression is not a constant expression. 3. Test that checks expression is a constant expression. 4. Test that checks template parameter support on function. NOTE: No change in compiler. All new test cases have already been supported. Signed-off-by: Soumi Manna <soumi.manna@intel.com>
romanovvlad
pushed a commit
that referenced
this pull request
Jan 26, 2021
…3089) Template parameter support was added for 1. [[intel::max_global_work_dim)]] attribute on #2816 2. [[intel::num_simd_work_items()]] attribute on #2510 3. [[intel::reqd_sub_group_size()]] attribute on #1807 This patch adds the following new test cases that were not there before to improve the support: 1. Test that checks wrong function template instantiation and ensures that the type is checked properly when instantiating from the template definition. 2. Test that checks expression is not a constant expression. 3. Test that checks expression is a constant expression. 4. Test that checks template parameter support on function. NOTE: No change in compiler. All new test cases have already been supported. Signed-off-by: Soumi Manna <soumi.manna@intel.com>
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
Fix bench template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
adds support for template parameter on [[intelfpga::num_simd_work_items()]] attribute
splits test/SemaSYCL/num_simd_work_items.cpp to separate files for
host compilation (test/SemaSYCL/num_simd_work_items_host.cpp) and
device compilation (test/SemaSYCL/num_simd_work_items_device.cpp)
makes changes to intel_reqd_sub_group_size attribute source codes
to avoid duplication and reuse for the template parameter support.
Signed-off-by: Soumi Manna soumi.manna@intel.com