-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL] Set stype for event pool descriptor #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@bader , @bso-intel seems fail is reported because of new warning:
What shall I do? |
It looks like tests hang
I've seen this before, so I hope it doesn't caused by this patch. Please, make sure that this issue is recorded already and re-run the job. |
Thanks!
what does this mean? |
There is a tracker for this issue. |
I think the hang is not related to my warning message. It seems the tests passed now. Let me know if this is still an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, the rebuild "fixed" it and the PR can be merged. |
…otential_race_condition Revert "Fix potential deadlock in the WaitEvent path of CmdBuffers"
…ial_race_condition Revert "Fix potential deadlock in the WaitEvent path of CmdBuffers"
See here, https://spec.oneapi.com/level-zero/latest/core/api.html?highlight=zeeventpoolcreate#ze-event-pool-desc-t. The "stype" is a new input field for the descriptors in Level-Zero v1.0.
Descriptors in v1.0 are now a linked list and have a "next" field, that allows you to pass extensions to any interface. So basically here we pass the basic descriptor (as we are doing) and then you could pass extensions through the next field if you want to instruct the Level-Zero driver to do something extra. The stype helps identifying which descriptor (if basic or extension) you are passing.
Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com