Skip to content

Conversation

smaslov-intel
Copy link
Contributor

See here, https://spec.oneapi.com/level-zero/latest/core/api.html?highlight=zeeventpoolcreate#ze-event-pool-desc-t. The "stype" is a new input field for the descriptors in Level-Zero v1.0.

Descriptors in v1.0 are now a linked list and have a "next" field, that allows you to pass extensions to any interface. So basically here we pass the basic descriptor (as we are doing) and then you could pass extensions through the next field if you want to instruct the Level-Zero driver to do something extra. The stype helps identifying which descriptor (if basic or extension) you are passing.

Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@bader bader changed the title [SYCL]: set stype for event pool descriptor [SYCL] Set stype for event pool descriptor Sep 22, 2020
@smaslov-intel
Copy link
Contributor Author

@bader , @bso-intel seems fail is reported because of new warning:

WARNING: The legacy environment variables SYCL_BE and SYCL_DEVICE_TYPE are deprecated. Please use SYCL_DEVICE_FILTER instead. For details, please refer to https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md

What shall I do?

@bader
Copy link
Contributor

bader commented Sep 23, 2020

@bader , @bso-intel seems fail is reported because of new warning:

WARNING: The legacy environment variables SYCL_BE and SYCL_DEVICE_TYPE are deprecated. Please use SYCL_DEVICE_FILTER instead. For details, please refer to https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md

It looks like tests hang

command timed out: 1200 seconds without output running [b'python3', b'llvm_ci/intel/worker/tools/build.py', b'-n', b'5291', b'-b', b'pull/2519/head', b'-r', b'2519', b'-t', b'check-sycl', b'-p', b'sycl', b'-s', b'lit', b'-P', b'intel/llvm', b'-m', b'sycl-ubu-x64-pr', b'-e', b'5f37d0b7f536fc5c6742c3abba4435e068d54aef', b'-U', b'http://ci.llvm.intel.com:8010/#/builders/2/builds/5291'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1534.365917

What shall I do?

I've seen this before, so I hope it doesn't caused by this patch. Please, make sure that this issue is recorded already and re-run the job.

@smaslov-intel
Copy link
Contributor Author

Thanks!

make sure that this issue is recorded already

what does this mean?

@bader
Copy link
Contributor

bader commented Sep 23, 2020

Thanks!

make sure that this issue is recorded already

what does this mean?

There is a tracker for this issue.

@bso-intel
Copy link
Contributor

@bader , @bso-intel seems fail is reported because of new warning:

WARNING: The legacy environment variables SYCL_BE and SYCL_DEVICE_TYPE are deprecated. Please use SYCL_DEVICE_FILTER instead. For details, please refer to https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md

What shall I do?

I think the hang is not related to my warning message. It seems the tests passed now. Let me know if this is still an issue.

Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smaslov-intel
Copy link
Contributor Author

Yes, the rebuild "fixed" it and the PR can be merged.

@pvchupin pvchupin merged commit a61e6a7 into intel:sycl Sep 23, 2020
kbenzie pushed a commit to kbenzie/intel-llvm that referenced this pull request Feb 17, 2025
…otential_race_condition

Revert "Fix potential deadlock in the WaitEvent path of CmdBuffers"
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
…ial_race_condition

Revert "Fix potential deadlock in the WaitEvent path of CmdBuffers"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants