[SYCL] Implement queue::parallel_for() accepting reduction #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Pennycook
reviewed
Oct 26, 2020
| template <typename KernelName = detail::auto_name, typename KernelType, | ||
| int Dims, typename Reduction> | ||
| event parallel_for(nd_range<Dims> ExecutionRange, Reduction Redu, | ||
| _KERNELFUNCPARAM(KernelFunc) _CODELOCPARAM(&CodeLoc)) { |
There was a problem hiding this comment.
I can see you didn't introduce this, but wanted to point out that I think the lack of a comma between these two macro-generated parameters looks really weird.
Pennycook
approved these changes
Oct 26, 2020
againull
approved these changes
Oct 26, 2020
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
…commandbuffer Add USMMemcpy to v2 command buffer
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ndbuffer Add USMMemcpy to v2 command buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the functionality provided by similar/other queue::parallel_for() methods
and allows passing reduction to them.
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com