[SYCL] Fix argument printing in PI trace #2961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
force-pushed
the
fixtrace
branch
from
f05aff4 to
a1a1266
Compare
Fix an issue where PI call arguments were printed after the call has been made, which led to incorrect values reported for out pointer arguments. Fixes SYCL/Tracing/pi_tracing_test.cpp from llvm-test-suite.
sergey-semenov
force-pushed
the
fixtrace
branch
from
a1a1266 to
f728070
Compare
romanovvlad
approved these changes
Dec 29, 2020
jsji
pushed a commit
that referenced
this pull request
Jan 26, 2025
Update for llvm-project commit abba01a ("[ADT] Deprecate PointerUnion::{is,get} (NFC) (#122623)", 2025-01-13). Original commit: KhronosGroup/SPIRV-LLVM-Translator@d9e871ae7e694dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where PI call arguments were printed after the call has
been made, which led to incorrect values reported for out pointer
arguments.
Fixes SYCL/Tracing/pi_tracing_test.cpp from llvm-test-suite.