Skip to content

Conversation

vladimirlaz
Copy link
Contributor

CMake target configuration is aligned with LIT test location.

That also alows to run on-device LIT tests for prebuilt SYCL compiler
and runtime binaries following the
instructions.

CMake target configuration is aligned with LIT test location.

That also alows to run on-device LIT tests for prebuilt SYCL compiler
and runtime binaries following the
[instructions](https://github.com/intel/llvm/blob/sycl/sycl/test/on-device/README.md).
pvchupin
pvchupin previously approved these changes Jan 14, 2021
Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Would be good to have review from others.

@vladimirlaz vladimirlaz marked this pull request as ready for review January 15, 2021 06:31
@vladimirlaz vladimirlaz requested a review from a team as a code owner January 15, 2021 06:31
@pvchupin
Copy link
Contributor

Good comments @romanovvlad, thank you!

also:
 - removed obsolete dependencies from the build;
 - add Level_Zero headers support to LIT infra to support
online_compiler/online_compiler_L0.cpp test;
 - add LEVEL_ZERO_INCLUDE_DIR to global scope to be used in tests;
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanovvlad romanovvlad merged commit 74809e4 into intel:sycl Jan 21, 2021
@vladimirlaz vladimirlaz deleted the revise_lit_cmakes branch April 23, 2021 06:27
iclsrc pushed a commit that referenced this pull request Mar 28, 2025
…3034)

This reverts commit bc94b7c3a637446748072a9e7fd883724bd6b4e5.

SPV_INTEL_complex_float_mul_div extension support is being removed from
SPIR-V
This PR cleans up the existing support in the translator.

Thanks

---------

Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@78ab5f393362cf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants