-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL][NFC] Revise Cmake config for LIT #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CMake target configuration is aligned with LIT test location. That also alows to run on-device LIT tests for prebuilt SYCL compiler and runtime binaries following the [instructions](https://github.com/intel/llvm/blob/sycl/sycl/test/on-device/README.md).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Would be good to have review from others.
Good comments @romanovvlad, thank you! |
also: - removed obsolete dependencies from the build; - add Level_Zero headers support to LIT infra to support online_compiler/online_compiler_L0.cpp test; - add LEVEL_ZERO_INCLUDE_DIR to global scope to be used in tests;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…3034) This reverts commit bc94b7c3a637446748072a9e7fd883724bd6b4e5. SPV_INTEL_complex_float_mul_div extension support is being removed from SPIR-V This PR cleans up the existing support in the translator. Thanks --------- Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@78ab5f393362cf1
CMake target configuration is aligned with LIT test location.
That also alows to run on-device LIT tests for prebuilt SYCL compiler
and runtime binaries following the
instructions.