[SYCL] Clean up shared events from queues upon reaching a threshold #3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the shared ownership of some events (USM and those without dependencies) by queues was released only upon calls to queue::wait/wait_and_throw(). If the application exclusively uses event::wait() instead, those events will be kept alive until the destruction of the queue. The patch addresses this problem by introducing a threshold on shared events associated with each queue. If that threshold is exceeded upon adding a new shared event for the queue, its events are queried for their execution status and the completed ones are released.
romanovvlad
reviewed
Jan 21, 2021
romanovvlad
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the shared ownership of some events (USM and those without
dependencies) by queues was released only upon calls to
queue::wait/wait_and_throw(). If the application uses exclusively
event::wait() instead, those events will be kept alive until the
destruction of the queue.
The patch addresses this problem by introducing a threshold on shared
events associated with each queue. If that threshold is exceeded upon
adding a new shared event to the queue, its events are queried for
their execution status and the completed ones are released.